Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: tools/metrics/actions/actions.xml

Issue 2868553003: [Home] Add more descriptive user actions for opening/closing the bottom sheet (Closed)
Patch Set: animations can end immediately Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetMetrics.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/actions/actions.xml
diff --git a/tools/metrics/actions/actions.xml b/tools/metrics/actions/actions.xml
index cb16b84ea1adf82a2ffc190e9374391d1606e942..c27814997d3fe3e05a207e3a505cd8a3c7ebf604 100644
--- a/tools/metrics/actions/actions.xml
+++ b/tools/metrics/actions/actions.xml
@@ -1122,6 +1122,38 @@ should be able to be added at any place in this file.
<description>User closed the Chrome Home bottom sheet.</description>
</action>
+<action name="Android.ChromeHome.ClosedByNTPCloseButton">
+ <owner>mdjones@chromium.org</owner>
+ <owner>twellington@chromium.org</owner>
+ <description>
+ User closed the Chrome Home bottom sheet using the NTP's close button.
+ </description>
+</action>
+
+<action name="Android.ChromeHome.ClosedByNavigation">
+ <owner>mdjones@chromium.org</owner>
+ <owner>twellington@chromium.org</owner>
+ <description>
+ User closed the Chrome Home bottom sheet navigating.
Theresa 2017/05/05 22:19:36 nit: bottom sheet by navigating
mdjones 2017/05/05 22:40:16 Done.
+ </description>
+</action>
+
+<action name="Android.ChromeHome.ClosedBySwipe">
+ <owner>mdjones@chromium.org</owner>
+ <owner>twellington@chromium.org</owner>
+ <description>
+ User closed the Chrome Home bottom sheet using a swipe gesture.
+ </description>
+</action>
+
+<action name="Android.ChromeHome.ClosedByTapScrim">
+ <owner>mdjones@chromium.org</owner>
+ <owner>twellington@chromium.org</owner>
+ <description>
+ User closed the Chrome Home bottom sheet tapping the scrim behind the sheet.
+ </description>
+</action>
+
<action name="Android.ChromeHome.FullState">
<owner>mdjones@chromium.org</owner>
<owner>twellington@chromium.org</owner>
@@ -1142,6 +1174,42 @@ should be able to be added at any place in this file.
<owner>mdjones@chromium.org</owner>
<owner>twellington@chromium.org</owner>
<description>User opened the Chrome Home bottom sheet.</description>
+ <obsolete>
+ Deprecated 5/2017. Replaced by the versions with a suffix, which are more
+ descriptive.
+ </obsolete>
+</action>
+
+<action name="Android.ChromeHome.OpenedByExpandButton">
+ <owner>mdjones@chromium.org</owner>
+ <owner>twellington@chromium.org</owner>
+ <description>
+ User opened the Chrome Home bottom sheet using the expand button.
+ </description>
+</action>
+
+<action name="Android.ChromeHome.OpenedByNTP">
+ <owner>mdjones@chromium.org</owner>
+ <owner>twellington@chromium.org</owner>
+ <description>
+ User opened the Chrome Home bottom sheet by opening a new tab.
+ </description>
+</action>
+
+<action name="Android.ChromeHome.OpenedByOmnibox">
+ <owner>mdjones@chromium.org</owner>
+ <owner>twellington@chromium.org</owner>
+ <description>
+ User opened the Chrome Home bottom sheet by focusing the omnibox.
+ </description>
+</action>
+
+<action name="Android.ChromeHome.OpenedBySwipe">
+ <owner>mdjones@chromium.org</owner>
+ <owner>twellington@chromium.org</owner>
+ <description>
+ User opened the Chrome Home bottom sheet using a swipe gesture.
+ </description>
</action>
<action name="Android.ChromeHome.ShowBookmarks">
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetMetrics.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698