Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 2868543003: Remove deprecated ProxyDelegate API (Closed)

Created:
3 years, 7 months ago by tbansal1
Modified:
3 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, bnc+watch_chromium.org, tbansal+watch-data-reduction-proxy_chromium.org, asvitkine+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove deprecated ProxyDelegate API API GetDefaultAlternativeProxy was added to the ProxyDelegate as part of data saver's QUIC experiment. This is no longer being used. BUG=455054 Review-Url: https://codereview.chromium.org/2868543003 Cr-Commit-Position: refs/heads/master@{#470630} Committed: https://chromium.googlesource.com/chromium/src/+/9b1cdf3635b3bede6dd3054fbd9650ae3f22243e

Patch Set 1 : ps #

Total comments: 4

Patch Set 2 : ryansturm comments #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -274 lines) Patch
M components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.h View 1 4 chunks +1 line, -16 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.cc View 1 3 chunks +1 line, -31 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate_unittest.cc View 1 3 chunks +0 lines, -144 lines 0 comments Download
M components/data_reduction_proxy/core/common/data_reduction_proxy_params.h View 1 chunk +0 lines, -3 lines 0 comments Download
M components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M components/data_reduction_proxy/core/common/data_reduction_proxy_params_unittest.cc View 2 chunks +8 lines, -15 lines 0 comments Download
M net/base/proxy_delegate.h View 1 chunk +0 lines, -4 lines 0 comments Download
M net/base/test_proxy_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/base/test_proxy_delegate.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M net/http/http_network_session.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M net/proxy/proxy_service_unittest.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M net/quic/chromium/quic_stream_factory.h View 1 3 chunks +0 lines, -3 lines 0 comments Download
M net/quic/chromium/quic_stream_factory.cc View 1 3 chunks +0 lines, -3 lines 2 comments Download
M net/quic/chromium/quic_stream_factory_test.cc View 1 6 chunks +10 lines, -31 lines 0 comments Download
M net/websockets/websocket_end_to_end_test.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/metrics/histograms/enums.xml View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 33 (21 generated)
tbansal1
ryansturm: ptal. Thanks.
3 years, 7 months ago (2017-05-06 01:08:08 UTC) #6
RyanSturm
https://codereview.chromium.org/2442633002 added some plumbing of proxy_delegate to quic_stream_factory that is unused and can be removed. ...
3 years, 7 months ago (2017-05-08 16:17:50 UTC) #13
tbansal1
rch: ptal at //net. holte: tools/metrics/histograms/* Thanks. https://codereview.chromium.org/2868543003/diff/40001/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.h File components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.h (right): https://codereview.chromium.org/2868543003/diff/40001/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.h#newcode15 components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.h:15: #include "net/proxy/proxy_server.h" ...
3 years, 7 months ago (2017-05-08 20:18:15 UTC) #17
Steven Holte
lgtm
3 years, 7 months ago (2017-05-08 20:18:41 UTC) #18
tbansal1
Also, ryansturm: ptal. Thanks.
3 years, 7 months ago (2017-05-08 20:19:39 UTC) #19
RyanSturm
lgtm
3 years, 7 months ago (2017-05-08 20:30:31 UTC) #20
Ryan Hamilton
lgtm https://codereview.chromium.org/2868543003/diff/60001/net/quic/chromium/quic_stream_factory.cc File net/quic/chromium/quic_stream_factory.cc (left): https://codereview.chromium.org/2868543003/diff/60001/net/quic/chromium/quic_stream_factory.cc#oldcode682 net/quic/chromium/quic_stream_factory.cc:682: proxy_delegate_(proxy_delegate), Was this member totally unused?
3 years, 7 months ago (2017-05-08 23:20:15 UTC) #23
tbansal1
https://codereview.chromium.org/2868543003/diff/60001/net/quic/chromium/quic_stream_factory.cc File net/quic/chromium/quic_stream_factory.cc (left): https://codereview.chromium.org/2868543003/diff/60001/net/quic/chromium/quic_stream_factory.cc#oldcode682 net/quic/chromium/quic_stream_factory.cc:682: proxy_delegate_(proxy_delegate), On 2017/05/08 23:20:15, Ryan Hamilton wrote: > Was ...
3 years, 7 months ago (2017-05-08 23:36:14 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2868543003/60001
3 years, 7 months ago (2017-05-09 19:26:06 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/449126)
3 years, 7 months ago (2017-05-10 01:21:52 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2868543003/60001
3 years, 7 months ago (2017-05-10 16:08:03 UTC) #30
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 17:28:58 UTC) #33
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/9b1cdf3635b3bede6dd3054fbd96...

Powered by Google App Engine
This is Rietveld 408576698