Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Unified Diff: components/exo/buffer.cc

Issue 2868473002: Implement aura::Window::CreateCompositorFrameSink() (Closed)
Patch Set: Address review issues Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/exo/buffer.h ('k') | components/exo/buffer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/exo/buffer.cc
diff --git a/components/exo/buffer.cc b/components/exo/buffer.cc
index 0588175c463eca7ef2847355f8e7bc24fa39587d..d2141c9d05025cbcada4f5af62332964581d9922 100644
--- a/components/exo/buffer.cc
+++ b/components/exo/buffer.cc
@@ -428,10 +428,6 @@ bool Buffer::ProduceTransferableResource(
return false;
}
- // The reference to the CompositorFrameSinkHolder keeps it alive until a
- // release callback is received.
- compositor_frame_sink_holder_ = compositor_frame_sink_holder;
-
resource->id = resource_id;
resource->format = cc::RGBA_8888;
resource->filter = GL_LINEAR;
@@ -462,7 +458,7 @@ bool Buffer::ProduceTransferableResource(
// The contents texture will be released when no longer used by the
// compositor.
- compositor_frame_sink_holder_->SetResourceReleaseCallback(
+ compositor_frame_sink_holder->SetResourceReleaseCallback(
resource_id,
base::Bind(&Buffer::Texture::ReleaseTexImage,
base::Unretained(contents_texture),
@@ -492,7 +488,7 @@ bool Buffer::ProduceTransferableResource(
// The mailbox texture will be released when no longer used by the
// compositor.
- compositor_frame_sink_holder_->SetResourceReleaseCallback(
+ compositor_frame_sink_holder->SetResourceReleaseCallback(
resource_id,
base::Bind(&Buffer::Texture::Release, base::Unretained(texture),
base::Bind(&Buffer::ReleaseTexture, AsWeakPtr(),
« no previous file with comments | « components/exo/buffer.h ('k') | components/exo/buffer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698