Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2676)

Unified Diff: chrome/browser/notifications/notification_platform_bridge_linux_unittest.cc

Issue 2868433004: Linux native notifications: use image_path instead of image-path for spec 1.1 (Closed)
Patch Set: use base::Version Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/notification_platform_bridge_linux_unittest.cc
diff --git a/chrome/browser/notifications/notification_platform_bridge_linux_unittest.cc b/chrome/browser/notifications/notification_platform_bridge_linux_unittest.cc
index c3bc7a1fb1596c735fe7e1949f6d9b1af8f721f1..db50aa69e4034ff4480f5058f056a0afc4e65183 100644
--- a/chrome/browser/notifications/notification_platform_bridge_linux_unittest.cc
+++ b/chrome/browser/notifications/notification_platform_bridge_linux_unittest.cc
@@ -44,6 +44,16 @@ ACTION_P(OnGetCapabilities, capabilities) {
return response;
}
+ACTION_P(OnGetServerInformation, spec_version) {
+ dbus::Response* response = dbus::Response::CreateEmpty().release();
+ dbus::MessageWriter writer(response);
+ writer.AppendString(""); // name
+ writer.AppendString(""); // vendor
+ writer.AppendString(""); // version
+ writer.AppendString(spec_version);
+ return response;
+}
+
ACTION_P(OnNotify, id) {
// The "Notify" message must have type (susssasa{sv}i).
// https://developer.gnome.org/notification-spec/#command-notify
@@ -142,6 +152,10 @@ class NotificationPlatformBridgeLinuxTest : public testing::Test {
MockCallMethodAndBlock(Calls("GetCapabilities"), _))
.WillOnce(OnGetCapabilities(std::vector<std::string>()));
+ EXPECT_CALL(*mock_notification_proxy_.get(),
+ MockCallMethodAndBlock(Calls("GetServerInformation"), _))
+ .WillOnce(OnGetServerInformation("1.2"));
+
EXPECT_CALL(
*mock_notification_proxy_.get(),
ConnectToSignal(kFreedesktopNotificationsName, "ActionInvoked", _, _))
« no previous file with comments | « chrome/browser/notifications/notification_platform_bridge_linux.cc ('k') | tools/metrics/histograms/enums.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698