Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1021)

Issue 2868433002: Revert "Remove status entries for now-passing checked-mode co19 tests that were returning a value f… (Closed)

Created:
3 years, 7 months ago by jensj
Modified:
3 years, 7 months ago
Reviewers:
Alan Knight, floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Remove status entries for now-passing checked-mode co19 tests that were returning a value from a void function" This reverts commit 47ba2bd413e56a5bba71780c0c7a256322693476. Reverting this because the commit causing these tests to pass was reverted. BUG= Committed: https://github.com/dart-lang/sdk/commit/d9e93a106705d211fd5e66a53c4687b33b2d5261

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M tests/co19/co19-dartium.status View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
jensj
tbr
3 years, 7 months ago (2017-05-05 07:31:47 UTC) #2
jensj
Committed patchset #1 (id:1) manually as d9e93a106705d211fd5e66a53c4687b33b2d5261 (presubmit successful).
3 years, 7 months ago (2017-05-05 07:32:06 UTC) #4
floitsch
3 years, 7 months ago (2017-05-06 16:25:23 UTC) #5
Message was sent while issue was closed.
LGTM. thanks.

Powered by Google App Engine
This is Rietveld 408576698