DevTools: Fixed handling of unexpected renderer termination

DevTools: Fixed handling of unexpected renderer termination

On Linux window updates properly after renderer is killed. Perhaps should be checked on Mac as well.

BUG=372504
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271349

[pfeldman, 2014-05-15 14:23:51]

https://codereview.chromium.org/286843002/diff/40001/chrome/browser/devtools/...
File chrome/browser/devtools/devtools_window.cc (right):

https://codereview.chromium.org/286843002/diff/40001/chrome/browser/devtools/...
chrome/browser/devtools/devtools_window.cc:1032: CloseContents(web_contents_);
Lets put it into CloseContents.

[pfeldman, 2014-05-16 10:25:52]

lgtm

[vkuzkokov, 2014-05-16 10:43:27]

The CQ bit was checked by vkuzkokov@chromium.org

[commit-bot: I haz the power, 2014-05-16 10:43:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vkuzkokov@chromium.org/286843002/60001

[commit-bot: I haz the power, 2014-05-16 13:39:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-16 13:39:07]

Failed to apply patch for @master/chrome/browser/devtools/devtools_window.cc:
While running svn add @master --force --config-dir
/b/infra_internal/commit_queue/subversion_config --non-interactive;
  svn: '@master' is just a peg revision. Maybe try '@master@' instead?

Patch:       @master/chrome/browser/devtools/devtools_window.cc
Index: chrome/browser/devtools/devtools_window.cc
diff --git @master/chrome/browser/devtools/devtools_window.cc
@master/chrome/browser/devtools/devtools_window.cc
index
da8615c14703f1527e6d3b42a82c26128f7d110c..34739f1c37cc7cc3d835eec5bdd0d660d05ef2de
100644
--- a/@master/chrome/browser/devtools/devtools_window.cc
+++ b/@master/chrome/browser/devtools/devtools_window.cc
@@ -752,6 +752,11 @@ void DevToolsWindow::AddNewContents(WebContents* source,
 
 void DevToolsWindow::CloseContents(WebContents* source) {
   CHECK(is_docked_);
+  // Do this first so that when GetDockedInstanceForInspectedTab is called
+  // from UpdateDevTools it won't return this instance
+  // see crbug.com/372504
+  content::DevToolsManager::GetInstance()->ClientHostClosing(
+      bindings_->frontend_host());
   // This will prevent any activity after frontend is loaded.
   action_on_load_ = DevToolsToggleAction::NoOp();
   ignore_set_is_docked_ = true;
@@ -1022,6 +1027,7 @@ InfoBarService* DevToolsWindow::GetInfoBarService() {
 void DevToolsWindow::RenderProcessGone() {
   // Docked DevToolsWindow owns its web_contents_ and must delete it.
   // Undocked web_contents_ are owned and handled by browser.
+  // see crbug.com/369932
   if (is_docked_)
     CloseContents(web_contents_);
 }

[vkuzkokov, 2014-05-19 07:12:54]

The CQ bit was checked by vkuzkokov@chromium.org

[commit-bot: I haz the power, 2014-05-19 07:13:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vkuzkokov@chromium.org/286843002/60001

[commit-bot: I haz the power, 2014-05-19 07:14:04]

Change committed as 271349