Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Unified Diff: third_party/WebKit/Source/core/workers/Worklet.h

Issue 2868413005: Worklet: Introduce WorkletOptions for addModule() (Closed)
Patch Set: add TODO comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/workers/Worklet.h
diff --git a/third_party/WebKit/Source/core/workers/Worklet.h b/third_party/WebKit/Source/core/workers/Worklet.h
index 9d9ba852c2bf01617552c7b72d4a191b83de5e86..0ca938ebe5d70473ec009b76e1decf2c4167f2f8 100644
--- a/third_party/WebKit/Source/core/workers/Worklet.h
+++ b/third_party/WebKit/Source/core/workers/Worklet.h
@@ -8,6 +8,7 @@
#include "bindings/core/v8/ScriptPromise.h"
#include "core/CoreExport.h"
#include "core/dom/ContextLifecycleObserver.h"
+#include "core/workers/WorkletOptions.h"
#include "platform/bindings/ScriptWrappable.h"
#include "platform/heap/Handle.h"
@@ -33,7 +34,9 @@ class CORE_EXPORT Worklet : public GarbageCollectedFinalized<Worklet>,
// Worklet.idl
// addModule() imports ES6 module scripts.
- virtual ScriptPromise addModule(ScriptState*, const String& module_url);
+ virtual ScriptPromise addModule(ScriptState*,
+ const String& module_url,
+ const WorkletOptions&);
// Returns a proxy to WorkletGlobalScope on the context thread.
virtual WorkletGlobalScopeProxy* GetWorkletGlobalScopeProxy() const = 0;
@@ -46,6 +49,7 @@ class CORE_EXPORT Worklet : public GarbageCollectedFinalized<Worklet>,
private:
virtual void FetchAndInvokeScript(const KURL& module_url_record,
+ const WorkletOptions&,
ScriptPromiseResolver*) = 0;
};

Powered by Google App Engine
This is Rietveld 408576698