Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(812)

Unified Diff: third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerListImpl.h

Issue 2868413002: [DMC #5.55] Add DocumentMarkerList::MarkerType() (Closed)
Patch Set: Fix mistake in comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerListImpl.h
diff --git a/third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerListImpl.h b/third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerListImpl.h
index ff3de05d1391139db2c952726c3d1a0c40daf3cb..def3f14199fc6dd88a144fb3e4d3245fbfc2ac4e 100644
--- a/third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerListImpl.h
+++ b/third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerListImpl.h
@@ -9,13 +9,13 @@
namespace blink {
-// Implementation of DocumentMarkerList for Spelling/Grammar markers.
-// Markers with touching endpoints are merged on insert. Markers are kept sorted
-// by start offset in order to be able to do this efficiently.
+// Nearly-complete implementation of DocumentMarkerList for Spelling or Grammar
+// markers (subclassed by SpellingMarkerListImpl and GrammarMarkerListImpl to
+// implement the MarkerType() method). Markers with touching endpoints are
+// merged on insert. Markers are kept sorted by start offset in order to be able
+// to do this efficiently.
class CORE_EXPORT SpellCheckMarkerListImpl : public DocumentMarkerList {
public:
- SpellCheckMarkerListImpl() = default;
-
// DocumentMarkerList implementations
bool IsEmpty() const final;
@@ -34,6 +34,9 @@ class CORE_EXPORT SpellCheckMarkerListImpl : public DocumentMarkerList {
DECLARE_VIRTUAL_TRACE();
+ protected:
+ SpellCheckMarkerListImpl() = default;
+
private:
HeapVector<Member<RenderedDocumentMarker>> markers_;

Powered by Google App Engine
This is Rietveld 408576698