third_party/WebKit/Source/core/editing/markers/GenericDocumentMarkerListImpl.h - Issue 2868413002: [DMC #5.55] Add DocumentMarkerList::MarkerType()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/markers/GenericDocumentMarkerListImpl.h

Issue 2868413002: [DMC #5.55] Add DocumentMarkerList::MarkerType() (Closed)

Patch Set: Fix mistake in comment Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h ('k') | third_party/WebKit/Source/core/editing/markers/GenericDocumentMarkerListImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/markers/GenericDocumentMarkerListImpl.h

diff --git a/third_party/WebKit/Source/core/editing/markers/GenericDocumentMarkerListImpl.h b/third_party/WebKit/Source/core/editing/markers/GenericDocumentMarkerListImpl.h

index bd148c554746c436bdbb5c4e0cfd33f491b23bba..216b9067c5ba85987489cb559c5f1c75604764c0 100644

--- a/third_party/WebKit/Source/core/editing/markers/GenericDocumentMarkerListImpl.h

+++ b/third_party/WebKit/Source/core/editing/markers/GenericDocumentMarkerListImpl.h

@@ -16,9 +16,11 @@ class RenderedDocumentMarker;

// specialized implementations for every MarkerType.

class GenericDocumentMarkerListImpl final : public DocumentMarkerList {

public:

- GenericDocumentMarkerListImpl() = default;

+ GenericDocumentMarkerListImpl(DocumentMarker::MarkerType);

// DocumentMarkerList implementations

+ DocumentMarker::MarkerType MarkerType() const final;

bool IsEmpty() const final;

void Add(DocumentMarker*) final;

@@ -37,6 +39,7 @@ class GenericDocumentMarkerListImpl final : public DocumentMarkerList {

DECLARE_TRACE();

private:

+ const DocumentMarker::MarkerType marker_type_;

HeapVector<Member<RenderedDocumentMarker>> markers_;

DISALLOW_COPY_AND_ASSIGN(GenericDocumentMarkerListImpl);