[DMC #5.55] Add DocumentMarkerList::MarkerType()

third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerListImplTest.cpp

 // Copyright 2017 The Chromium Authors. All rights reserved.  Use of
 // this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/editing/markers/SpellCheckMarkerListImpl.h"
 
 #include "core/editing/markers/RenderedDocumentMarker.h"
 #include "platform/heap/Handle.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace blink {
 
+class SpellCheckMarkerListImplForTesting : public SpellCheckMarkerListImpl {

[yosin_UTC9, 2017/05/12 05:00:04]

We can use SpellingMarkerList and GrammarMakrerList here instead of introducing
test only class.

[rlanday, 2017/05/12 21:07:02]

Can you please clarify what you mean by "and"? Do you mean I should just use
SpellingMarkerListImpl, or that I should write a parameterized test that runs
all the test cases with both SpellingMarkerListImpl and GrammarMarkerListImpl,
or is there another option you want me to do?

[yosin_UTC9, 2017/05/15 04:03:04]

I propose having only "SpellingMarkerListImplTest.cpp" and
"GrammerMarkerListImpl.cpp":
 - SpellingMarkerListImpl: test all SpellingCheckerMakrerListImpl functions +
type checks
 - GrammarMakerListImpl: type checks + a comment mentions
"GrammerMarkerListImpl's member functions are implemented in
SpellCheckingMarkerListImpl and they are testing SpllingMarkerListImpl".

For simplicity and avoid test code duplication.

+  DocumentMarker::MarkerType MarkerType() const final {
+    return DocumentMarker::kSpelling;
+  }
+};
+
 class SpellCheckMarkerListImplTest : public ::testing::Test {
  protected:
   SpellCheckMarkerListImplTest()
-      : marker_list_(new SpellCheckMarkerListImpl()) {}
+      : marker_list_(new SpellCheckMarkerListImplForTesting()) {}
 
   DocumentMarker* CreateMarker(unsigned start_offset, unsigned end_offset) {
     return new DocumentMarker(DocumentMarker::kSpelling, start_offset,
                               end_offset, g_empty_string);
   }
 
   Persistent<SpellCheckMarkerListImpl> marker_list_;
 };
 
 TEST_F(SpellCheckMarkerListImplTest, AddSorting) {
@@ skipping 114 matching lines @@
   EXPECT_EQ(2u, marker_list_->GetMarkers().size());
 
   EXPECT_EQ(0u, marker_list_->GetMarkers()[0]->StartOffset());
   EXPECT_EQ(3u, marker_list_->GetMarkers()[0]->EndOffset());
 
   EXPECT_EQ(9u, marker_list_->GetMarkers()[1]->StartOffset());
   EXPECT_EQ(14u, marker_list_->GetMarkers()[1]->EndOffset());
 }
 
 }  // namespace