third_party/WebKit/Source/core/editing/markers/GrammarMarkerListImpl.h - Issue 2868413002: [DMC #5.55] Add DocumentMarkerList::MarkerType()

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/editing/markers/GrammarMarkerListImpl.h

Issue 2868413002: [DMC #5.55] Add DocumentMarkerList::MarkerType() (Closed)

Patch Set: Add missing files Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef GrammarMarkerListImpl_h

	6 #define GrammarMarkerListImpl_h

	7

	8 #include "core/editing/markers/SpellCheckMarkerListImpl.h"

	9

	10 namespace blink {

	11

	12 class GrammarMarkerListImpl : public SpellCheckMarkerListImpl {
	yosin_UTC9 2017/05/12 05:00:04 Please add class documentation. nit: s/:/final : / Please add class documentation. nit: s/:/final : /
	13 public:

	14 DocumentMarker::MarkerType MarkerType() const;
	yosin_UTC9 2017/05/12 05:00:03 nit: s/const/const final/ nit: s/const/const final/
	15 };
	yosin_UTC9 2017/05/12 05:00:04 We should have DISALLOW_COPY_AND_ASSIGN() We should have DISALLOW_COPY_AND_ASSIGN()
	16

	17 } // namespace blink

	18

	19 #endif // GrammarMarkerListImpl_h

OLD	NEW