Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Unified Diff: chrome/android/java/res/layout/tabular_context_menu.xml

Issue 2868403003: added scale animation for context menu (Closed)
Patch Set: fixing broken tests Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/layout/tabular_context_menu.xml
diff --git a/chrome/android/java/res/layout/tabular_context_menu.xml b/chrome/android/java/res/layout/tabular_context_menu.xml
index 6b408c28c7dfd0966ddf09af0ef886d0b408b278..f29c6b90324e2563427ab9cdc240bd9d7de166ca 100644
--- a/chrome/android/java/res/layout/tabular_context_menu.xml
+++ b/chrome/android/java/res/layout/tabular_context_menu.xml
@@ -2,24 +2,34 @@
<!-- Copyright 2017 The Chromium Authors. All rights reserved.
Use of this source code is governed by a BSD-style license that can be
found in the LICENSE file. -->
-<org.chromium.chrome.browser.contextmenu.TabularContextMenuViewPager
+<FrameLayout
xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto"
- android:id="@+id/custom_pager"
- android:layout_width="wrap_content"
- android:layout_height="wrap_content"
- android:layout_marginTop="20dp"
- android:layout_marginBottom="20dp"
- android:minWidth="280dp">
- <android.support.design.widget.TabLayout
- android:id="@+id/tab_layout"
- android:layout_width="match_parent"
+ android:id="@+id/context_menu_frame_layout"
+ android:background="@color/modal_dialog_scrim_color" >
+
+ <org.chromium.chrome.browser.contextmenu.TabularContextMenuViewPager
+ android:id="@+id/custom_pager"
+ android:background="@drawable/white_with_rounded_corners"
+ android:layout_width="wrap_content"
android:layout_height="wrap_content"
- android:background="@color/google_grey_100"
- app:tabTextColor="#80000000"
- app:tabSelectedTextColor="@color/light_active_color"
- app:tabIndicatorColor="@color/light_active_color"
- app:tabGravity="fill"
- app:tabMaxWidth="0dp"
- app:tabMode="fixed" />
-</org.chromium.chrome.browser.contextmenu.TabularContextMenuViewPager>
+ android:layout_marginTop="20dp"
+ android:layout_marginBottom="20dp"
+ android:minWidth="280dp"
+ android:layout_gravity="center">
+
+ <!-- tabMaxWidth is required otherwise tabGravity will have no effect when the context menu
+ gets too large. -->
+ <android.support.design.widget.TabLayout
+ android:id="@+id/tab_layout"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:background="@color/google_grey_100"
+ app:tabTextColor="@color/black_alpha_54"
+ app:tabSelectedTextColor="@color/light_active_color"
+ app:tabIndicatorColor="@color/light_active_color"
+ app:tabGravity="fill"
+ app:tabMode="fixed"
+ app:tabMaxWidth="2000dp" />
+ </org.chromium.chrome.browser.contextmenu.TabularContextMenuViewPager>
+</FrameLayout>
« no previous file with comments | « chrome/android/java/res/drawable/grey_with_top_rounded_corners.xml ('k') | chrome/android/java/res/values/dimens.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698