 Chromium Code Reviews
 Chromium Code Reviews Issue 2868403003:
  added scale animation for context menu  (Closed)
    
  
    Issue 2868403003:
  added scale animation for context menu  (Closed) 
  | Index: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuParams.java | 
| diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuParams.java b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuParams.java | 
| index 58ae91dc2b7201840ecdd89b6f6820b0564e36c3..0aab28fed0fec5590dcc8b0acd3bd6a40b23e0e9 100644 | 
| --- a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuParams.java | 
| +++ b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuParams.java | 
| @@ -43,6 +43,9 @@ public class ContextMenuParams { | 
| private final boolean mIsVideo; | 
| private final boolean mCanSavemedia; | 
| + private final int mTriggeringTouchX; | 
| + private final int mTriggeringTouchY; | 
| + | 
| /** | 
| * @return The URL associated with the main frame of the page that triggered the context menu. | 
| */ | 
| @@ -134,10 +137,26 @@ public class ContextMenuParams { | 
| return false; | 
| } | 
| + /** | 
| + * @return The x-coordinate of the touch that triggered the context menu in dp relative to the | 
| + * render view; 0 corresponds to the left edge. | 
| + */ | 
| + public int getTriggeringTouchX() { | 
| 
Ted C
2017/05/30 23:04:04
I would put a Dp suffix here and below
 
Daniel Park
2017/05/31 18:19:38
Done.
 | 
| + return mTriggeringTouchX; | 
| + } | 
| + | 
| + /** | 
| + * @return The y-coordinate of the touch that triggered the context menu in dp relative to the | 
| + * render view; 0 corresponds to the left edge. | 
| + */ | 
| + public int getTriggeringTouchY() { | 
| + return mTriggeringTouchY; | 
| + } | 
| + | 
| @VisibleForTesting | 
| ContextMenuParams(int mediaType, String pageUrl, String linkUrl, String linkText, | 
| String unfilteredLinkUrl, String srcUrl, String titleText, boolean imageWasFetchedLoFi, | 
| - Referrer referrer, boolean canSavemedia) { | 
| + Referrer referrer, boolean canSavemedia, int triggeringTouchX, int triggeringTouchY) { | 
| mPageUrl = pageUrl; | 
| mLinkUrl = linkUrl; | 
| mLinkText = linkText; | 
| @@ -151,16 +170,19 @@ public class ContextMenuParams { | 
| mIsImage = mediaType == MediaType.MEDIA_TYPE_IMAGE; | 
| mIsVideo = mediaType == MediaType.MEDIA_TYPE_VIDEO; | 
| mCanSavemedia = canSavemedia; | 
| + mTriggeringTouchX = triggeringTouchX; | 
| + mTriggeringTouchY = triggeringTouchY; | 
| } | 
| @CalledByNative | 
| private static ContextMenuParams create(int mediaType, String pageUrl, String linkUrl, | 
| String linkText, String unfilteredLinkUrl, String srcUrl, String titleText, | 
| boolean imageWasFetchedLoFi, String sanitizedReferrer, int referrerPolicy, | 
| - boolean canSavemedia) { | 
| + boolean canSavemedia, int triggeringTouchX, int triggeringTouchY) { | 
| Referrer referrer = TextUtils.isEmpty(sanitizedReferrer) | 
| ? null : new Referrer(sanitizedReferrer, referrerPolicy); | 
| return new ContextMenuParams(mediaType, pageUrl, linkUrl, linkText, unfilteredLinkUrl, | 
| - srcUrl, titleText, imageWasFetchedLoFi, referrer, canSavemedia); | 
| + srcUrl, titleText, imageWasFetchedLoFi, referrer, canSavemedia, triggeringTouchX, | 
| + triggeringTouchY); | 
| } | 
| } |