chrome/android/java/res/layout/tabular_context_menu.xml - Issue 2868403003: added scale animation for context menu

Unified Diff: chrome/android/java/res/layout/tabular_context_menu.xml

Issue 2868403003: added scale animation for context menu (Closed)

Patch Set: creating a new contextmenudialog constructor Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « chrome/android/java/res/drawable/grey_with_top_rounded_corners.xml ('k') | chrome/android/java/res/values/dimens.xml » ('j') | chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/layout/tabular_context_menu.xml

diff --git a/chrome/android/java/res/layout/tabular_context_menu.xml b/chrome/android/java/res/layout/tabular_context_menu.xml

index 11998c6ed39020b97d1cfc6545f41ae002ae768d..5e228d9dacaf964b7a13e67b00547d802f74f6fd 100644

--- a/chrome/android/java/res/layout/tabular_context_menu.xml

+++ b/chrome/android/java/res/layout/tabular_context_menu.xml

@@ -2,23 +2,32 @@

Use of this source code is governed by a BSD-style license that can be

found in the LICENSE file. -->

-<org.chromium.chrome.browser.contextmenu.TabularContextMenuViewPager

+<FrameLayout

xmlns:android="http://schemas.android.com/apk/res/android"

xmlns:app="http://schemas.android.com/apk/res-auto"

- android:id="@+id/custom_pager"

- android:layout_width="wrap_content"

- android:layout_height="wrap_content"

- android:layout_marginTop="20dp"

- android:layout_marginBottom="20dp"

- android:minWidth="280dp">

- <android.support.design.widget.TabLayout

- android:id="@+id/tab_layout"

+ android:id="@+id/context_menu_frame_layout"

+ android:background="@color/modal_dialog_scrim_color" >

+ <org.chromium.chrome.browser.contextmenu.TabularContextMenuViewPager

Theresa 2017/05/30 16:16:07 nit: add a blank line before this line and above t

Daniel Park 2017/05/30 17:40:40 Done.

+ android:id="@+id/custom_pager"

+ android:background="@drawable/white_with_rounded_corners"

android:layout_width="match_parent"

android:layout_height="wrap_content"

- android:background="@color/google_grey_100"

- app:tabTextColor="#80000000"

- app:tabSelectedTextColor="@color/light_active_color"

- app:tabIndicatorColor="@color/light_active_color"

- app:tabGravity="fill"

- app:tabMode="fixed" />

-</org.chromium.chrome.browser.contextmenu.TabularContextMenuViewPager>

+ android:layout_marginTop="20dp"

+ android:layout_marginBottom="20dp"

+ android:minWidth="280dp"

+ android:layout_gravity="center">

+ <!-- tabMaxWidth is required otherwise tabGravity will have no effect when the context menu

+ gets too large. -->

+ <android.support.design.widget.TabLayout

+ android:id="@+id/tab_layout"

+ android:layout_width="wrap_content"

+ android:layout_height="wrap_content"

+ android:background="@color/google_grey_100"

+ app:tabTextColor="@color/black_alpha_54"

+ app:tabSelectedTextColor="@color/light_active_color"

+ app:tabIndicatorColor="@color/light_active_color"

+ app:tabGravity="fill"

+ app:tabMode="fixed"

+ app:tabMaxWidth="2000dp" />

+ </org.chromium.chrome.browser.contextmenu.TabularContextMenuViewPager>

+</FrameLayout>