Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1023)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java

Issue 2868403003: added scale animation for context menu (Closed)
Patch Set: refactoring Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java
index cd508545aa7a47b1b2f4e3f3a30fdb72ef67c7fa..2835ba81b4f733d92454bd4e6e9afe15ab50265d 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java
@@ -115,26 +115,27 @@ public class ContextMenuHelper implements OnCreateContextMenuListener {
List<Pair<Integer, List<ContextMenuItem>>> items =
mPopulator.buildContextMenu(null, mActivity, mCurrentContextMenuParams);
- final ContextMenuUi menuUi = new TabularContextMenuUi(new Runnable() {
+ final TabularContextMenuUi menuUi = new TabularContextMenuUi(new Runnable() {
@Override
public void run() {
shareImageDirectly(ShareHelper.getLastShareComponentName());
}
});
+ menuUi.setRenderCoordinates(contentViewCore.getRenderCoordinates());
menuUi.displayMenu(mActivity, mCurrentContextMenuParams, items, mCallback, mOnMenuShown,
mOnMenuClosed);
if (mCurrentContextMenuParams.isImage()) {
getThumbnail(new Callback<Bitmap>() {
@Override
public void onResult(Bitmap result) {
- ((TabularContextMenuUi) menuUi).onImageThumbnailRetrieved(result);
+ menuUi.onImageThumbnailRetrieved(result);
}
});
}
return;
}
- // The Platform Context Menu requires the listener within this hepler since this helper and
+ // The Platform Context Menu requires the listener within this helper since this helper and
// provides context menu for us to show.
view.setOnCreateContextMenuListener(this);
if (view.showContextMenu()) {

Powered by Google App Engine
This is Rietveld 408576698