Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3512)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java

Issue 2868403003: added scale animation for context menu (Closed)
Patch Set: y Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java
index cd508545aa7a47b1b2f4e3f3a30fdb72ef67c7fa..3a83337abc41d32191cf72c6287bfdfa5bc574b2 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java
@@ -121,6 +121,8 @@ public class ContextMenuHelper implements OnCreateContextMenuListener {
shareImageDirectly(ShareHelper.getLastShareComponentName());
}
});
+ ((TabularContextMenuUi) menuUi)
Theresa 2017/05/24 17:53:33 Instead of casting here, let's change line 118 to:
Daniel Park 2017/05/24 19:44:38 Done.
+ .setRenderCoordinates(contentViewCore.getRenderCoordinates());
menuUi.displayMenu(mActivity, mCurrentContextMenuParams, items, mCallback, mOnMenuShown,
mOnMenuClosed);
if (mCurrentContextMenuParams.isImage()) {
@@ -134,7 +136,7 @@ public class ContextMenuHelper implements OnCreateContextMenuListener {
return;
}
- // The Platform Context Menu requires the listener within this hepler since this helper and
+ // The Platform Context Menu requires the listener within this helper since this helper and
// provides context menu for us to show.
view.setOnCreateContextMenuListener(this);
if (view.showContextMenu()) {

Powered by Google App Engine
This is Rietveld 408576698