added scale animation for context menu

chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.contextmenu;
 
 import android.app.Activity;
-import android.app.Dialog;
 import android.content.DialogInterface;
 import android.content.res.Resources;
 import android.graphics.Bitmap;
 import android.graphics.Canvas;
 import android.graphics.Shader;
 import android.graphics.drawable.BitmapDrawable;
 import android.graphics.drawable.Drawable;
 import android.support.design.widget.TabLayout;
-import android.support.v4.view.ViewPager;
 import android.support.v7.app.AlertDialog;
 import android.text.TextUtils;
 import android.util.Pair;
 import android.view.LayoutInflater;
 import android.view.View;
 import android.view.ViewGroup;
 import android.widget.AdapterView;
 import android.widget.BaseAdapter;
 import android.widget.ImageView;
 import android.widget.ListView;
 import android.widget.TextView;
 
 import org.chromium.base.ApiCompatibilityUtils;
 import org.chromium.base.Callback;
 import org.chromium.base.VisibleForTesting;
 import org.chromium.chrome.R;
+import org.chromium.chrome.browser.widget.ContextMenuDialog;
+import org.chromium.content.browser.RenderCoordinates;
 
 import java.util.ArrayList;
 import java.util.List;
 
 /**
  * A custom dialog that separates each group into separate tabs. It uses a dialog instead.
  */
 public class TabularContextMenuUi implements ContextMenuUi, AdapterView.OnItemClickListener {
-    private Dialog mDialog;
+    private static final double MAX_WIDTH_PROPORTION = 0.75;
+
+    private ContextMenuDialog mContextMenuDialog;
     private Callback<Integer> mCallback;
     private int mMenuItemHeight;
     private ImageView mHeaderImageView;
     private Runnable mOnShareItemClicked;
+    private View mPagerView;
+    private RenderCoordinates mRenderCoordinates;
 
     public TabularContextMenuUi(Runnable onShareItemClicked) {
         mOnShareItemClicked = onShareItemClicked;
     }
 
     @Override
-    public void displayMenu(Activity activity, ContextMenuParams params,
+    public void displayMenu(final Activity activity, ContextMenuParams params,
             List<Pair<Integer, List<ContextMenuItem>>> items, Callback<Integer> onItemClicked,
             final Runnable onMenuShown, final Runnable onMenuClosed) {
         mCallback = onItemClicked;
-        mDialog = createDialog(activity, params, items);
 
-        mDialog.getWindow().setBackgroundDrawable(ApiCompatibilityUtils.getDrawable(
-                activity.getResources(), R.drawable.white_with_rounded_corners));
+        float density = Resources.getSystem().getDisplayMetrics().density;
+        final float touchPointX = params.getTriggeringTouchX() * density;
+        final float touchPointY = params.getTriggeringTouchY() * density;
 
-        mDialog.setOnShowListener(new DialogInterface.OnShowListener() {
+        mContextMenuDialog =
+                createContextMenuDialog(activity, params, items, touchPointX, touchPointY);
+
+        mContextMenuDialog.setOnShowListener(new DialogInterface.OnShowListener() {
             @Override
             public void onShow(DialogInterface dialogInterface) {
                 onMenuShown.run();
             }
         });
 
-        mDialog.setOnDismissListener(new DialogInterface.OnDismissListener() {
+        mContextMenuDialog.setOnDismissListener(new DialogInterface.OnDismissListener() {
             @Override
             public void onDismiss(DialogInterface dialogInterface) {
                 onMenuClosed.run();
             }
         });
 
-        mDialog.show();
+        mContextMenuDialog.show();
     }
 
     /**
      * Returns the fully complete dialog based off the params and the itemGroups.
+     *
      * @param activity Used to inflate the dialog.
      * @param params Used to get the header title.
      * @param itemGroups If there is more than one group it will create a paged view.
+     * @param touchPointY The x-coordinate of the touch that triggered the context menu in pixels.

[Ted C, 2017/05/30 23:04:04]

I would just put a suffix of Px and then you can drop "in pixels" in the comment

[Daniel Park, 2017/05/31 18:19:39]

Done.

+     * @param touchPointX The y-coordinate of the touch that triggered the context menu in pixels.
      * @return Returns a final dialog that does not have a background can be displayed using
      *         {@link AlertDialog#show()}.
      */
-    private Dialog createDialog(Activity activity, ContextMenuParams params,
-            List<Pair<Integer, List<ContextMenuItem>>> itemGroups) {
-        Dialog dialog = new Dialog(activity);
-        dialog.setContentView(createPagerView(activity, params, itemGroups));
+    private ContextMenuDialog createContextMenuDialog(Activity activity, ContextMenuParams params,
+            List<Pair<Integer, List<ContextMenuItem>>> itemGroups, float touchPointX,
+            float touchPointY) {
+        View view = LayoutInflater.from(activity).inflate(R.layout.tabular_context_menu, null);
+
+        Resources resources = activity.getResources();
+
+        int contextMenuWidth =
+                (int) Math.min(resources.getDisplayMetrics().widthPixels * MAX_WIDTH_PROPORTION,

[Ted C, 2017/05/30 23:04:04]

Does widthPixels change if you rotate the phone?  If you show the dialog in
landscape and rotate, does this need to be updated?

For the narrowest of phones, I'm a bit worried that 75% might be too limiting. 
I wonder if we should instead have a min padding from the edge (I was thinking
something like 10-15 dp).  Although if this is what UX decided on, then that is
ok.  We should just try on our smallest phone to make sure that doesn't hurt
anything (or try multi-window in landscape on a phone)

[Daniel Park, 2017/05/31 18:19:39]

Acknowledged.

[Daniel Park, 2017/05/31 18:19:39]

There's an issue where rotating the screen from landscape to portrait will cause
the context menu to be wider than the phone's width. 
I'll fix that & change it to the minimum padding in a future cl.

[Ted C, 2017/06/02 22:51:40]

As discussed offline, that is ok in this context as the UI is behind a flag, but
normally it would need to be fixed here.

Let's file a bug and add a TODO here:

// TODO(injae): Fix sizing on orientation changes (crbug.com/XXXXX).

As for the min sizing, I think we should just go ahead and change that in this
CL.  Instead of doing MAX_WIDTH_PROPORTION, let's define a new dimen in xml (I'd
say 20dp) called context_menu_min_side_padding and do widthPixels - 2 * min
padding.  I think if it isn't wide enough, we should take up more than 75% of
the screen.  That is likely a small enough change to warrant doing it here
instead of filing a separate bug.

+                        resources.getDimensionPixelSize(R.dimen.context_menu_max_width));
+
+        mPagerView = initPagerView(activity, params, itemGroups,
+                (TabularContextMenuViewPager) view.findViewById(R.id.custom_pager));
+        mPagerView.getLayoutParams().width = contextMenuWidth;
+
+        final ContextMenuDialog dialog = new ContextMenuDialog(activity, R.style.DialogWhenLarge,
+                touchPointX, touchPointY, mPagerView, mRenderCoordinates);
+        dialog.setContentView(view);
+
         return dialog;
     }
 
     /**
      * Creates a ViewPageAdapter based off the given list of views.
-     * @param activity Used to inflate the new ViewPager
+     *
+     * @param activity Used to inflate the new ViewPager.
      * @param params Used to get the header text.
      * @param itemGroups The list of views to put into the ViewPager. The string is the title of the
-     *                   tab
+     *                   tab.
+     * @param viewPager The {@link TabularContextMenuViewPager} to initialize.
      * @return Returns a complete tabular context menu view.
      */
     @VisibleForTesting
-    View createPagerView(Activity activity, ContextMenuParams params,
-            List<Pair<Integer, List<ContextMenuItem>>> itemGroups) {
-        View view = LayoutInflater.from(activity).inflate(R.layout.tabular_context_menu, null);
-
+    View initPagerView(Activity activity, ContextMenuParams params,
+            List<Pair<Integer, List<ContextMenuItem>>> itemGroups,
+            TabularContextMenuViewPager viewPager) {
         List<Pair<String, ViewGroup>> viewGroups = new ArrayList<>();
         int maxCount = 0;
         for (int i = 0; i < itemGroups.size(); i++) {
             Pair<Integer, List<ContextMenuItem>> itemGroup = itemGroups.get(i);
             maxCount = Math.max(maxCount, itemGroup.second.size());
         }
         for (int i = 0; i < itemGroups.size(); i++) {
             Pair<Integer, List<ContextMenuItem>> itemGroup = itemGroups.get(i);
             // TODO(tedchoc): Pass the ContextMenuGroup identifier to determine if it's an image.
             boolean isImageTab = itemGroup.first == R.string.contextmenu_image_title;
             viewGroups.add(new Pair<>(activity.getString(itemGroup.first),
                     createContextMenuPageUi(
                             activity, params, itemGroup.second, isImageTab, maxCount)));
         }
-        if (itemGroups.size() == 1) {
-            viewGroups.get(0)
-                    .second.getChildAt(0)
-                    .findViewById(R.id.context_header_layout)
-                    .setBackgroundResource(R.color.google_grey_100);
-        }
 
-        TabularContextMenuViewPager pager =
-                (TabularContextMenuViewPager) view.findViewById(R.id.custom_pager);
-        pager.setAdapter(new TabularContextMenuPagerAdapter(viewGroups));
-
-        TabLayout tabLayout = (TabLayout) view.findViewById(R.id.tab_layout);
+        viewPager.setAdapter(new TabularContextMenuPagerAdapter(viewGroups));
+        TabLayout tabLayout = (TabLayout) viewPager.findViewById(R.id.tab_layout);
         if (itemGroups.size() <= 1) {
             tabLayout.setVisibility(View.GONE);
         } else {
-            tabLayout.setupWithViewPager((ViewPager) view.findViewById(R.id.custom_pager));
+            tabLayout.setBackgroundResource(R.drawable.grey_with_top_rounded_corners);
+            tabLayout.setupWithViewPager(viewPager);
         }
 
-        return view;
+        return viewPager;
     }
 
     /**
      * Creates the view of a context menu. Based off the Context Type, it'll adjust the list of
      * items and display only the ones that'll be on that specific group.
+     *
      * @param activity Used to get the resources of an item.
      * @param params used to create the header text.
      * @param items A set of Items to display in a context menu. Filtered based off the type.
      * @param isImage Whether or not the view should have an image layout or not.
      * @param maxCount The maximum amount of {@link ContextMenuItem}s that could exist in this view
      *                 or any other views calculated in the context menu. Used to estimate the size
      *                 of the list.
      * @return Returns a filled LinearLayout with all the context menu items.
      */
     @VisibleForTesting
@@ skipping 10 matching lines @@
             baseLayout.findViewById(R.id.context_header_layout).setVisibility(View.VISIBLE);
             baseLayout.findViewById(R.id.context_divider).setVisibility(View.VISIBLE);
             displayImageHeader(baseLayout, params, activity.getResources());
         }
 
         // Set the list adapter and get the height to display it appropriately in a dialog.
         Runnable onDirectShare = new Runnable() {
             @Override
             public void run() {
                 mOnShareItemClicked.run();
-                mDialog.dismiss();
+                mContextMenuDialog.dismiss();
             }
         };
         TabularContextMenuListAdapter listAdapter =
                 new TabularContextMenuListAdapter(items, activity, onDirectShare);
         ViewGroup.LayoutParams layoutParams = listView.getLayoutParams();
         layoutParams.height = measureApproximateListViewHeight(listView, listAdapter, maxCount);
         listView.setLayoutParams(layoutParams);
         listView.setAdapter(listAdapter);
         listView.setOnItemClickListener(this);
 
@@ skipping 52 matching lines @@
         BitmapDrawable bm = new BitmapDrawable(resources, bitmap);
         bm.setTileModeXY(Shader.TileMode.REPEAT, Shader.TileMode.REPEAT);
         imageView.setVisibility(View.VISIBLE);
         imageView.setBackground(bm);
     }
 
     /**
      * To save time measuring the height, this method gets an item if the height has not been
      * previous measured and multiplies it by count of the total amount of items. It is fine if the
      * height too small as the ListView will scroll through the other values.
+     *
      * @param listView The ListView to measure the surrounding padding.
      * @param listAdapter The adapter which contains the items within the list.
      * @return Returns the combined height of the padding of the ListView and the approximate height
      *         of the ListView based off the an item.
      */
     private int measureApproximateListViewHeight(
             ListView listView, BaseAdapter listAdapter, int maxCount) {
         int totalHeight = listView.getPaddingTop() + listView.getPaddingBottom();
         if (mMenuItemHeight == 0 && !listAdapter.isEmpty()) {
             View view = listAdapter.getView(0, null, listView);
             view.measure(View.MeasureSpec.makeMeasureSpec(0, View.MeasureSpec.UNSPECIFIED),
                     View.MeasureSpec.makeMeasureSpec(0, View.MeasureSpec.UNSPECIFIED));
             mMenuItemHeight = view.getMeasuredHeight();
         }
         return totalHeight + mMenuItemHeight * maxCount;
     }
 
     /**
-     * When an thumbnail is retrieved for the header of an image, this will set the header to
-     * that particular bitmap.
+     * When an thumbnail is retrieved for the header of an image, this will set the header to that
+     * particular bitmap.
      */
     public void onImageThumbnailRetrieved(Bitmap bitmap) {
         if (mHeaderImageView != null) {
             mHeaderImageView.setImageBitmap(bitmap);
         }
     }
 
     @Override
     public void onItemClick(AdapterView<?> adapterView, View view, int position, long id) {
-        mDialog.dismiss();
+        mContextMenuDialog.dismiss();
         mCallback.onResult((int) id);
     }
+
+    /**
+     * Gives this class access to the render coordinates to allow access to the total size of the
+     * toolbar and tab strip.
+     */
+    public void setRenderCoordinates(RenderCoordinates renderCoordinates) {
+        mRenderCoordinates = renderCoordinates;
+    }
 }