chrome/android/java/res/layout/tabular_context_menu.xml - Issue 2868403003: added scale animation for context menu

Side by Side Diff: chrome/android/java/res/layout/tabular_context_menu.xml

Issue 2868403003: added scale animation for context menu (Closed)

Patch Set: y Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « chrome/android/java/res/drawable/grey_with_top_rounded_corners.xml ('k') | chrome/android/java/res/values/dimens.xml » ('j') | chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2017 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2017 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file. -->	4 found in the LICENSE file. -->

5 <org.chromium.chrome.browser.contextmenu.TabularContextMenuViewPager	5 <FrameLayout

6 xmlns:android="http://schemas.android.com/apk/res/android"	6 xmlns:android="http://schemas.android.com/apk/res/android"

7 xmlns:app="http://schemas.android.com/apk/res-auto"	7 xmlns:app="http://schemas.android.com/apk/res-auto"

8 android:id="@+id/custom_pager"	8 android:id="@+id/context_menu_frame_layout"

9 android:layout_width="wrap_content"	9 android:background="@color/modal_dialog_scrim_color" >

10 android:layout_height="wrap_content"	10 <org.chromium.chrome.browser.contextmenu.TabularContextMenuViewPager

11 android:layout_marginTop="20dp"	11 android:id="@+id/custom_pager"

12 android:layout_marginBottom="20dp"	12 android:background="@drawable/white_with_rounded_corners"

13 android:minWidth="280dp">

14 <android.support.design.widget.TabLayout

15 android:id="@+id/tab_layout"

16 android:layout_width="match_parent"	13 android:layout_width="match_parent"

17 android:layout_height="wrap_content"	14 android:layout_height="wrap_content"

18 android:background="@color/google_grey_100"	15 android:layout_marginTop="20dp"

19 app:tabTextColor="#80000000"	16 android:layout_marginBottom="20dp"

20 app:tabSelectedTextColor="@color/light_active_color"	17 android:minWidth="280dp"

21 app:tabIndicatorColor="@color/light_active_color"	18 android:layout_gravity="center">

22 app:tabGravity="fill"	19 <android.support.design.widget.TabLayout

23 app:tabMode="fixed" />	20 android:id="@+id/tab_layout"

24 </org.chromium.chrome.browser.contextmenu.TabularContextMenuViewPager>	21 android:layout_width="wrap_content"

	22 android:layout_height="wrap_content"

	23 android:background="@color/google_grey_100"

	24 app:tabTextColor="#80000000"
	Theresa 2017/05/24 17:53:33 nit: While not a change introduced in this CL, all nit: While not a change introduced in this CL, all color should be defined in colors.xml so that we can more easily track them. Also, #80000000 isn't in our recently formed color spec. #8A000000 (54% black), however, is, so we should use that instead. Daniel Park 2017/05/24 19:44:38 Done. Show quoted text On 2017/05/24 17:53:33, Theresa wrote: > nit: While not a change introduced in this CL, all color should be defined in > colors.xml so that we can more easily track them. Also, > #80000000 isn't in our recently formed color spec. #8A000000 (54% black), > however, is, so we should use that instead. Done.
	25 app:tabSelectedTextColor="@color/light_active_color"

	26 app:tabIndicatorColor="@color/light_active_color"

	27 app:tabGravity="fill"

	28 app:tabMode="fixed"

	29 app:tabMaxWidth="2000dp" />

	30 </org.chromium.chrome.browser.contextmenu.TabularContextMenuViewPager>

	31 </FrameLayout>

OLD	NEW