Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: remoting/ios/app/client_connection_view_controller.mm

Issue 2868383003: [CRD iOS] Send key events to the session. (Closed)
Patch Set: Update based on feedback. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/ios/app/BUILD.gn ('k') | remoting/ios/app/host_view_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/ios/app/client_connection_view_controller.mm
diff --git a/remoting/ios/app/client_connection_view_controller.mm b/remoting/ios/app/client_connection_view_controller.mm
index 5426c122ae79df7e0fb14567d496be183f716b15..108419a9465612640fabb73a34246276b126b8c5 100644
--- a/remoting/ios/app/client_connection_view_controller.mm
+++ b/remoting/ios/app/client_connection_view_controller.mm
@@ -31,6 +31,8 @@ static const CGFloat kMargin = 20.f;
static const CGFloat kBarHeight = 58.f;
+static const CGFloat kKeyboardAnimationTime = 0.3;
+
@interface ClientConnectionViewController ()<PinEntryDelegate> {
UIImageView* _iconView;
MDCActivityIndicator* _activityIndicator;
@@ -175,12 +177,12 @@ static const CGFloat kBarHeight = 58.f;
- (void)keyboardWillShow:(NSNotification*)notification {
CGSize keyboardSize =
- [[[notification userInfo] objectForKey:UIKeyboardFrameBeginUserInfoKey]
+ [[[notification userInfo] objectForKey:UIKeyboardFrameEndUserInfoKey]
CGRectValue]
.size;
[UIView
- animateWithDuration:0.3
+ animateWithDuration:kKeyboardAnimationTime
animations:^{
CGRect f = self.view.frame;
CGFloat newHeight =
@@ -196,7 +198,7 @@ static const CGFloat kBarHeight = 58.f;
}
- (void)keyboardWillHide:(NSNotification*)notification {
- [UIView animateWithDuration:0.3
+ [UIView animateWithDuration:kKeyboardAnimationTime
animations:^{
CGRect f = self.view.frame;
f.origin.y = 0.f;
« no previous file with comments | « remoting/ios/app/BUILD.gn ('k') | remoting/ios/app/host_view_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698