remoting/client/chromoting_session.h - Issue 2868383003: [CRD iOS] Send key events to the session.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/client/chromoting_session.h

Issue 2868383003: [CRD iOS] Send key events to the session. (Closed)

Patch Set: Removing the simple keyboard, not needed. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/client/chromoting_session.h

diff --git a/remoting/client/chromoting_session.h b/remoting/client/chromoting_session.h

index 8f67c653d0152f563db7fe95a1b8d1e6d581efe9..4b8c1c7d2883834c26c90a4cb6f2d446a75f6dc6 100644

--- a/remoting/client/chromoting_session.h

+++ b/remoting/client/chromoting_session.h

@@ -115,8 +115,11 @@ class ChromotingSession : public ClientUserInterface,

void SendMouseWheelEvent(int delta_x, int delta_y);

// Sends the provided keyboard scan code to the host.

+ // TODO(nicholss): sending scan code here is really weird.

+ // Can we fix this up so scan_code != 0 is it's own api endpoint?

bool SendKeyEvent(int scan_code, int key_code, bool key_down);

+ // Send utf8 encoded text to the host.

void SendTextEvent(const std::string& text);

// Sends the provided touch event payload to the host.