Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: remoting/client/chromoting_session.h

Issue 2868383003: [CRD iOS] Send key events to the session. (Closed)
Patch Set: Adding backspace support to the keyboard. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/client/chromoting_session.h
diff --git a/remoting/client/chromoting_session.h b/remoting/client/chromoting_session.h
index 8f67c653d0152f563db7fe95a1b8d1e6d581efe9..3de6c81023bfdae64eac2a33bcf4abd24008fd07 100644
--- a/remoting/client/chromoting_session.h
+++ b/remoting/client/chromoting_session.h
@@ -115,8 +115,14 @@ class ChromotingSession : public ClientUserInterface,
void SendMouseWheelEvent(int delta_x, int delta_y);
// Sends the provided keyboard scan code to the host.
+ // TODO(nicholss): sending scan code here is really weird.
+ // Can we fix this up so scan_code != 0 is it's own api endpoint?
bool SendKeyEvent(int scan_code, int key_code, bool key_down);
+ // Sends the usb key code to the host.
+ bool SendKeyEvent(int usb_key_code, bool key_down);
Yuwei 2017/05/15 19:38:06 FYI it's not recommended to overload functions in
nicholss 2017/05/15 23:06:10 Acknowledged.
+
+ // Send utf8 encoded text to the host.
void SendTextEvent(const std::string& text);
// Sends the provided touch event payload to the host.

Powered by Google App Engine
This is Rietveld 408576698