[CRD iOS] Send key events to the session.

remoting/client/chromoting_session.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/client/chromoting_session.h"
 
 #include <stdint.h>
 
 #include "base/bind.h"
 #include "base/callback_helpers.h"
@@ skipping 186 matching lines @@
   if (!usb_key_code) {
     LOG(WARNING) << "Ignoring unknown key code: " << key_code
                  << " scan code: " << scan_code;
     return false;
   }
 
   SendKeyEventInternal(usb_key_code, key_down);
   return true;
 }
 
+bool ChromotingSession::SendKeyEvent(int key_code, bool key_down) {
+  SendKeyEventInternal(key_code, key_down);
+  return true;
+}

[joedow, 2017/05/12 19:13:17]

Drive-by: This code looks a bit like the function above (param names) and the
above function has logic for 'software keyboards'.  Why not implement
'NativeDeviceKeycodeToUsbKeycode' for iOS and reuse the existing method?

To add on, if you decide to keep this method, please document it so people
reading the code know why this override was added (since it is similar to the
method above).

Edit: I just saw that you implemented that method for iOS, do you still need a
new method here?

[nicholss, 2017/05/12 20:45:57]

I have updated to use usb_key_code as the param name, the android version sends
device keycode which we do not have in iOS and need to convert ascii to usb
keycode directly. The above function assumes to much.

+
 void ChromotingSession::SendTextEvent(const std::string& text) {
   if (!runtime_->network_task_runner()->BelongsToCurrentThread()) {
     runtime_->network_task_runner()->PostTask(
         FROM_HERE,
         base::Bind(&ChromotingSession::SendTextEvent, GetWeakPtr(), text));
     return;
   }
 
   protocol::TextEvent event;
   event.set_text(text);
@@ skipping 232 matching lines @@
   video_renderer_.reset();
   signaling_.reset();
   perf_tracker_.reset();
   client_context_.reset();
   cursor_shape_stub_.reset();
 
   weak_factory_.InvalidateWeakPtrs();
 }
 
 }  // namespace remoting