remoting/client/native_device_keymap.cc - Issue 2868383003: [CRD iOS] Send key events to the session.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: remoting/client/native_device_keymap.cc

Issue 2868383003: [CRD iOS] Send key events to the session. (Closed)

Patch Set: Removing the simple keyboard, not needed. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2017 The Chromium Authors. All rights reserved.	1 // Copyright 2017 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "remoting/client/native_device_keymap.h"	5 #include "remoting/client/native_device_keymap.h"

6	6

7 namespace remoting {	7 namespace remoting {

8	8

9 // Default implementation.	9 // Default implementation.

10 uint32_t NativeDeviceKeycodeToUsbKeycode(size_t device_keycode) {	10 uint32_t NativeDeviceKeycodeToUsbKeycode(size_t device_keycode) {

	11 NOTIMPLEMENTED();
	Yuwei 2017/05/16 00:47:30 Will this be used by WebApp? If not I think we can Will this be used by WebApp? If not I think we can just remove this file? nicholss 2017/05/16 17:13:39 The app will not link for windows builds that also Show quoted text On 2017/05/16 00:47:30, Yuwei wrote: > Will this be used by WebApp? If not I think we can just remove this file? The app will not link for windows builds that also build the client build. So I don't think removing the stub is good.
11 return device_keycode;	12 return device_keycode;

12 }	13 }

13	14

14 } // namespace remoting	15 } // namespace remoting

OLD	NEW