[CRD iOS] Send key events to the session.

remoting/ios/app/client_connection_view_controller.mm

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #if !defined(__has_feature) || !__has_feature(objc_arc)
 #error "This file requires ARC support."
 #endif
 
 #import "remoting/ios/app/client_connection_view_controller.h"
 
@@ skipping 13 matching lines @@
 
 static const CGFloat kPinEntryViewWidth = 240.f;
 static const CGFloat kPinEntryViewHeight = 90.f;
 
 static const CGFloat kCenterShift = -80.f;
 static const CGFloat kPadding = 20.f;
 static const CGFloat kMargin = 20.f;
 
 static const CGFloat kBarHeight = 58.f;
 
+static const CGFloat kKeyboardAnimationTime = 0.3;

[Yuwei, 2017/05/15 19:38:07]

0.3f? Although the compiler might be clever enough to skip the conversion...

[nicholss, 2017/05/15 23:06:11]

##.f should be the same as ##.0, but style wise I have seen more ##.f if it is a
whole number and 0.# if < 1.0

So .f is only needed for whole numbers

[Yuwei, 2017/05/16 00:47:30]

Technically speaking 0.3 is a double precision float while 0.3f is single.

+
 @interface ClientConnectionViewController ()<PinEntryDelegate> {
   UIImageView* _iconView;
   MDCActivityIndicator* _activityIndicator;
   UILabel* _statusLabel;
   MDCNavigationBar* _navBar;
   PinEntryView* _pinEntryView;
   NSString* _remoteHostName;
 }
 @end
 
@@ skipping 124 matching lines @@
 - (void)viewWillDisappear:(BOOL)animated {
   [super viewWillDisappear:animated];
   [_activityIndicator stopAnimating];
   [[NSNotificationCenter defaultCenter] removeObserver:self];
 }
 
 #pragma mark - Keyboard
 
 - (void)keyboardWillShow:(NSNotification*)notification {
   CGSize keyboardSize =
-      [[[notification userInfo] objectForKey:UIKeyboardFrameBeginUserInfoKey]
+      [[[notification userInfo] objectForKey:UIKeyboardFrameEndUserInfoKey]
           CGRectValue]
           .size;
 
   [UIView
-      animateWithDuration:0.3
+      animateWithDuration:kKeyboardAnimationTime
                animations:^{
                  CGRect f = self.view.frame;
                  CGFloat newHeight =
                      self.view.frame.size.height - keyboardSize.height;
                  CGFloat overlap =
                      newHeight - (_pinEntryView.frame.origin.y +
                                   _pinEntryView.frame.size.height + kPadding);
                  if (overlap < 0) {
                    f.origin.y = overlap;
                    self.view.frame = f;
                  }
                }];
 }
 
 - (void)keyboardWillHide:(NSNotification*)notification {
-  [UIView animateWithDuration:0.3
+  [UIView animateWithDuration:kKeyboardAnimationTime
                    animations:^{
                      CGRect f = self.view.frame;
                      f.origin.y = 0.f;
                      self.view.frame = f;
                    }];
 }
 
 #pragma mark - Properties
 
 - (void)setState:(ClientConnectionViewState)state {
@@ skipping 104 matching lines @@
     default:
       LOG(ERROR) << "Unknown State for Session, " << sessionDetails.state;
       return;
   }
   [[NSOperationQueue mainQueue] addOperationWithBlock:^{
     [self setState:state];
   }];
 }
 
 @end