remoting/client/native_device_keymap.cc - Issue 2868383003: [CRD iOS] Send key events to the session.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: remoting/client/native_device_keymap.cc

Issue 2868383003: [CRD iOS] Send key events to the session. (Closed)

Patch Set: Adding backspace support to the keyboard. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2017 The Chromium Authors. All rights reserved.	1 // Copyright 2017 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "remoting/client/native_device_keymap.h"	5 #include "remoting/client/native_device_keymap.h"

6	6

7 namespace remoting {	7 namespace remoting {

8	8

9 // Default implementation.	9 // Default implementation.

10 uint32_t NativeDeviceKeycodeToUsbKeycode(size_t device_keycode) {	10 uint32_t NativeDeviceKeycodeToUsbKeycode(size_t device_keycode) {

	11 NOTIMPLEMENTED();

11 return device_keycode;	12 return device_keycode;

12 }	13 }

13	14

	15 // Default implementation.

	16 KeycodeWithModifier AsciiToUsbKeycodeWithModifier(const char& ascii) {
	Do not use (sergeyu) 2017/05/15 22:15:12 I don't think we want to use reference for this pa I don't think we want to use reference for this parameter. Char is cheaper to pass by value nicholss 2017/05/15 23:06:11 I don't need the method anymore. But good to know! Show quoted text On 2017/05/15 22:15:12, Do not use (sergeyu) wrote: > I don't think we want to use reference for this parameter. Char is cheaper to > pass by value I don't need the method anymore. But good to know!
	17 NOTIMPLEMENTED();

	18 return NULL;

	19 }

	20

14 } // namespace remoting	21 } // namespace remoting

OLD	NEW