[CRD iOS] Send key events to the session.

remoting/client/input/keyboard_input_strategy.h

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef REMOTING_CLIENT_INPUT_KEYBOARD_INPUT_STRATEGY_H_
+#define REMOTING_CLIENT_INPUT_KEYBOARD_INPUT_STRATEGY_H_
+
+#include <stdint.h>
+#include <string>
+
+namespace remoting {
+
+struct KeyEvent {
+  uint32_t keycode;
+  bool keydown;
+};
+
+// This is an interface used by |KeyboardInterpreter| to customize how keyboard
+// input is handled.
+class KeyboardInputStrategy {
+ public:
+  virtual ~KeyboardInputStrategy() {}
+
+  // Handle a text event.
+  virtual void HandleTextEvent(const std::string& text, uint8_t modifiers) = 0;

[Do not use (sergeyu), 2017/05/15 22:15:12]

Please add documentation for modifiers. Where are the corresponding values
defined? Is there any reason it needs to be uint8_t instead of int?

[nicholss, 2017/05/15 23:06:10]

I am not sure how I am going to use them yet. The original plan was to use a bit
mask hence why I am using an unsigned int here. But the implementation details
for modifiers is set for next milestone so I wanted to pass on dealing with
them. There is a todo in the impl and I will document what we decide at that
time.

+  // Handle delete event.
+  virtual void HandleDeleteEvent(uint8_t modifiers) = 0;
+};
+
+}  // namespace remoting
+#endif  // REMOTING_CLIENT_INPUT_KEYBOARD_INPUT_STRATEGY_H_

[Do not use (sergeyu), 2017/05/15 22:15:12]

nit: empty line here please. Same in other files

[nicholss, 2017/05/15 23:06:10]

Strange, I have one locally in all files.