Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2868353002: Enable analysis driver in tests where possible (Closed)

Created:
3 years, 7 months ago by Brian Wilkerson
Modified:
3 years, 7 months ago
Reviewers:
scheglov, danrubel
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -0 lines) Patch
M pkg/analysis_server/test/analysis/get_hover_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/domain_analysis_test.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/domain_execution_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/edit/format_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/edit/refactoring_test.dart View 5 chunks +25 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/search/element_references_test.dart View 2 chunks +12 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/search/member_declarations_test.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/search/top_level_declarations_test.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/search/type_hierarchy_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/src/domain_abstract_test.dart View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
I plan to reverse the sense of the flag at some point (unless someone else ...
3 years, 7 months ago (2017-05-10 15:43:07 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-10 15:44:02 UTC) #3
danrubel
LGTM
3 years, 7 months ago (2017-05-10 15:56:43 UTC) #4
Brian Wilkerson
3 years, 7 months ago (2017-05-10 16:13:30 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e6c8092ceada29c1e165cb370852b5d6eb947442 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698