Chromium Code Reviews Chromium Code Reviews
Issue 2868283002:
[css-grid] Check if baseline alignment affects grid areas sizing (Closed)
| Index: third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/self-baseline/grid-self-baseline-changes-grid-area-size-001.html |
| diff --git a/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/self-baseline/grid-self-baseline-changes-grid-area-size-001.html b/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/self-baseline/grid-self-baseline-changes-grid-area-size-001.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..dfd2e6173b6dfc42c6a527db0344084affd41ef0 |
| --- /dev/null |
| +++ b/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/self-baseline/grid-self-baseline-changes-grid-area-size-001.html |
| @@ -0,0 +1,54 @@ |
| +<!DOCTYPE html> |
| +<meta charset="utf-8"> |
| +<title>CSS Grid Layout Test: Self-Baseline alignment may change grid area height on fixed-sized grid</title> |
|
Manuel Rego
2017/05/11 14:10:08
You can whether put a simpler title (that probably
jfernandez
2017/05/11 21:51:30
Done.
|
| +<link rel="author" title="Javier Fernandez Garcia-Boente" href="mailto:jfernandez@igalia.com"> |
| +<link rel="help" href="https://drafts.csswg.org/css-align-3/#baseline-align-self"> |
| +<link rel="help" href="https://drafts.csswg.org/css-align-3/#align-by-baseline"> |
| +<link rel="match" href="../../../reference/ref-filled-green-100px-square.xht"> |
| +<meta name="assert" content="Column-Axis Self-Baseline alignment may change grid area height."> |
| +<style> |
| +.block { |
| + position: absolute; |
| + z-index: -1; |
| + background: green; |
| + width: 100px; |
| + height: 100px; |
| +} |
| +.block > div { |
| + position: absolute; |
| + color: red; |
| +} |
| +.grid { |
| + display: grid; |
| + width: 100px; |
| + height: 100px; |
| + font: 10px/1 Ahem; |
| + color: green; |
| + grid-auto-columns: 50px; |
| + align-items: baseline; |
| + align-content: start; |
| +} |
| +.i1 { |
|
Manuel Rego
2017/05/11 14:10:08
Please use more descriptive class names like "firs
jfernandez
2017/05/11 21:51:30
Done.
|
| + grid-row: 1; |
| + grid-column: 1; |
| +} |
| +.i2 { |
| + grid-row: 1; |
| + grid-column: 2; |
| + font: 20px/1 Ahem; |
|
Manuel Rego
2017/05/11 14:10:08
Nit: "font-size: 20px" should be enough.
Maybe mov
jfernandez
2017/05/11 21:51:30
Done.
|
| +} |
| +.i3 { |
| + grid-row: 2; |
| + grid-column: 1; |
| +} |
| +</style> |
| +<p>Test passes if there is a filled green square and <strong>no red</strong>.</p> |
| +<div class="block"> |
| + <div style="top: 8px; left: 0px; font: 10px/1 Ahem">XX<br>XXXX<br>XX<br>XX X</div> |
|
Manuel Rego
2017/05/11 14:10:08
Nit: maybe set "font: 10px/1 Ahem;" on ".block" cl
jfernandez
2017/05/11 21:51:30
Done.
|
| + <div style="top: 0px; left: 50px; font: 20px/1 Ahem">X</div> |
|
Manuel Rego
2017/05/11 14:10:08
And then only use "font-size: 20px;" here.
jfernandez
2017/05/11 21:51:30
Done.
|
| +</div> |
| +<div class="grid"> |
| + <div class="i1">XX XXXX XX</div> |
| + <div class="i2">X</div> |
| + <div class="i3">XX X</div> |
| +</div> |
