third_party/WebKit/Source/core/layout/LayoutGrid.h - Issue 2868283002: [css-grid] Check if baseline alignment affects grid areas sizing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutGrid.h

Issue 2868283002: [css-grid] Check if baseline alignment affects grid areas sizing (Closed)

Patch Set: Applied suggested changes. Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutGrid.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutGrid.h b/third_party/WebKit/Source/core/layout/LayoutGrid.h

index c15b45c5f8eb79979ca9ecae922bbb2243f53c1f..762ef697aef86485101759187262501e4ee4ee6c 100644

--- a/third_party/WebKit/Source/core/layout/LayoutGrid.h

+++ b/third_party/WebKit/Source/core/layout/LayoutGrid.h

@@ -269,8 +269,7 @@ class LayoutGrid final : public LayoutBlock {

LayoutUnit ascent,

GridAxis) const;

- bool BaselineMayAffectIntrinsicWidth() const;

- bool BaselineMayAffectIntrinsicHeight() const;

+ bool BaselineMayAffectIntrinsicSize(GridTrackSizingDirection) const;

void ComputeBaselineAlignmentContext();

void UpdateBaselineAlignmentContextIfNeeded(LayoutBox&, GridAxis);