Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2868233003: Remove unnecessary tests (Closed)

Created:
3 years, 7 months ago by Brian Wilkerson
Modified:
3 years, 7 months ago
Reviewers:
scheglov, danrubel
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -91 lines) Patch
M pkg/analysis_server/test/domain_completion_test.dart View 3 chunks +0 lines, -27 lines 0 comments Download
M pkg/analysis_server/test/edit/refactoring_test.dart View 2 chunks +0 lines, -40 lines 0 comments Download
M pkg/analysis_server/test/search/element_references_test.dart View 3 chunks +0 lines, -24 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
As far as I can tell, we no longer generate the NO_INDEX_GENERATED error, which means ...
3 years, 7 months ago (2017-05-10 16:03:52 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-10 16:09:23 UTC) #3
Brian Wilkerson
Committed patchset #1 (id:1) manually as 2a4772a537fcec0059d3b24c32ffe70dc394e340 (presubmit successful).
3 years, 7 months ago (2017-05-10 16:15:40 UTC) #5
danrubel
3 years, 7 months ago (2017-05-10 16:32:31 UTC) #6
Message was sent while issue was closed.
LGTM. Thanks!

Powered by Google App Engine
This is Rietveld 408576698