Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeBasicsTest.java

Issue 286823002: [Android Java Bridge] Recycle old V8 wrapper objects on navigations (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/java/java_bridge_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeBasicsTest.java
diff --git a/content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeBasicsTest.java b/content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeBasicsTest.java
index b6d98c6b0fb7c90e5982bb8824ed3b06ccef15ee..3ce9a2cf1e172caeca2c488ee9f1875f1517a42b 100644
--- a/content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeBasicsTest.java
+++ b/content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeBasicsTest.java
@@ -333,12 +333,13 @@ public class JavaBridgeBasicsTest extends JavaBridgeTestBase {
@SmallTest
@Feature({"AndroidWebView", "Android-JavaBridge"})
- public void testClientPropertiesPersistAcrossPageLoads() throws Throwable {
+ public void testCustomPropertiesCleanedUpOnPageReloads() throws Throwable {
assertEquals("object", executeJavaScriptAndGetStringResult("typeof testController"));
executeJavaScript("testController.myProperty = 42;");
assertEquals("42", executeJavaScriptAndGetStringResult("testController.myProperty"));
synchronousPageReload();
- assertEquals("42", executeJavaScriptAndGetStringResult("testController.myProperty"));
+ assertEquals("object", executeJavaScriptAndGetStringResult("typeof testController"));
+ assertEquals("undefined", executeJavaScriptAndGetStringResult("testController.myProperty"));
}
@SmallTest
« no previous file with comments | « no previous file | content/renderer/java/java_bridge_dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698