Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 286823002: [Android Java Bridge] Recycle old V8 wrapper objects on navigations (Closed)

Created:
6 years, 7 months ago by mnaganov (inactive)
Modified:
6 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, benm (inactive)
Visibility:
Public.

Description

[Android Java Bridge] Recycle old V8 wrapper objects on navigations When browser navigates to another page, make sure we de-associate NPObjects of injected Java objects from their old V8 wrappers. Not doing this leads to potential leaks of JS objects from one context to another. BUG=372914 R=jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271002

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeBasicsTest.java View 1 chunk +3 lines, -2 lines 0 comments Download
M content/renderer/java/java_bridge_dispatcher.cc View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
mnaganov (inactive)
Jochen, are you comfortable with reviewing this, or should I ask other people whom I ...
6 years, 7 months ago (2014-05-14 15:39:35 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 7 months ago (2014-05-15 10:40:07 UTC) #2
mnaganov (inactive)
The CQ bit was checked by mnaganov@chromium.org
6 years, 7 months ago (2014-05-16 09:15:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnaganov@chromium.org/286823002/1
6 years, 7 months ago (2014-05-16 09:16:29 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-16 11:00:40 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-16 11:02:47 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/builds/16993)
6 years, 7 months ago (2014-05-16 11:02:47 UTC) #7
mnaganov (inactive)
6 years, 7 months ago (2014-05-16 12:41:37 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r271002 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698