[MD settings] content exceptions with embeddingOrigin as read-only

chrome/browser/resources/settings/site_settings/site_list.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'site-list' shows a list of Allowed and Blocked sites for a given
  * category.
  */
 Polymer({
@@ skipping 169 matching lines @@
    * @private
    */
   hasSites_: function() {
     return !!this.sites.length;
   },
 
   /**
    * @param {chrome.settingsPrivate.Enforcement} enforcement The level of
    *     enforcement.
    * @param {boolean} readOnlyList Whether the site exception list is read-only.
+   * @param {!SiteException} item The content setting exception.

[dpapad, 2017/05/10 21:44:57]

Nit: Maybe a more descriptive name would be |exception| instead of |item|? Same
below.

[dschuyler, 2017/05/10 22:05:37]

Done.

    * @return {boolean}
    * @private
    */
-  isResetButtonHidden_: function(enforcement, readOnlyList) {
+  isResetButtonHidden_: function(enforcement, readOnlyList, item) {

[dpapad, 2017/05/10 21:44:57]

Nit (optional): I think it would improve readability to rename as follows

isResetButtonHidden_ -> shouldHideResetButton_
isActionMenuHidden_ -> shouldHideActionMenu_

The current naming reverses the cause-effect relationship. What I expect as a
reader when I see the contents of "isResetButtonHidden_" is something like

return this.$$('#resetButton').hidden;

Whereas in reality we use the value returned by the function to hide/show the
element.

[dschuyler, 2017/05/10 22:05:37]

Done.

     return enforcement == chrome.settingsPrivate.Enforcement.ENFORCED ||
-        this.allSites || !readOnlyList;
+        this.allSites || !(readOnlyList || !!item.embeddingOrigin);
   },
 
   /**
    * @param {string} enforcement Whether the exception is controlled.
    * @param {boolean} readOnlyList Whether the site exception list is read-only.
+   * @param {!SiteException} item The content setting exception.
    * @return {boolean}
    * @private
    */
-  isActionMenuHidden_: function(enforcement, readOnlyList) {
+  isActionMenuHidden_: function(enforcement, readOnlyList, item) {
     return enforcement == chrome.settingsPrivate.Enforcement.ENFORCED ||
-        this.allSites || readOnlyList;
+        this.allSites || readOnlyList || !!item.embeddingOrigin;
   },
 
   /**
    * A handler for the Add Site button.
    * @param {!Event} e
    * @private
    */
   onAddSiteTap_: function(e) {
     assert(!this.readOnlyList);
     e.preventDefault();
@@ skipping 278 matching lines @@
   /** @private */
   closeActionMenu_: function() {
     this.actionMenuSite_ = null;
     this.activeDialogAnchor_ = null;
     var actionMenu = /** @type {!CrActionMenuElement} */ (
         this.$$('dialog[is=cr-action-menu]'));
     if (actionMenu.open)
       actionMenu.close();
   },
 });