chrome/browser/page_load_metrics/metrics_web_contents_observer.cc - Issue 2868213003: Various cleanups for page_load_metrics_browsertest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

Issue 2868213003: Various cleanups for page_load_metrics_browsertest (Closed)

Patch Set: address comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

diff --git a/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc b/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

index 044495e8c15477c6feb9d26f3b8e58b564fdebe0..c75afcf77008fc1cbe486ffe2a98184705031ce0 100644

--- a/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

+++ b/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

@@ -607,7 +607,7 @@ void MetricsWebContentsObserver::OnTimingUpdated(

committed_load_->UpdateTiming(timing, metadata);

for (auto& observer : testing_observers_)

- observer.OnTimingUpdated(timing, metadata);

+ observer.OnTimingUpdated(true /* is_main_frame */, timing, metadata);

}

bool MetricsWebContentsObserver::ShouldTrackNavigation(