Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: tools/perf/benchmarks/blink_perf.py

Issue 2868183002: Fix breakage when blink_perf benchmarks are run without --browser flag (Closed)
Patch Set: Fix BlinkPerf default value Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/blink_perf.py
diff --git a/tools/perf/benchmarks/blink_perf.py b/tools/perf/benchmarks/blink_perf.py
index 7491f125d83ba087a437d5f03185aa58263abe93..413735ee15276aebe24a047741c5e8143a6eb535 100644
--- a/tools/perf/benchmarks/blink_perf.py
+++ b/tools/perf/benchmarks/blink_perf.py
@@ -166,7 +166,10 @@ class _BlinkPerfMeasurement(legacy_page_test.LegacyPageTest):
# TODO(qinmin): After fixing crbug.com/592017, remove this command line.
'--reduce-security-for-testing'
])
- if 'content-shell' in options.browser_type:
+
+ def SetOptions(self, options):
+ super(_BlinkPerfMeasurement, self).SetOptions(options)
nednguyen 2017/05/10 09:54:47 The logic of adding "--expose-internals-for-testin
Xianzhu 2017/05/10 15:48:34 I see that the blink_gc test suite is using this c
+ if 'content-shell' in options.browser_options.browser_type:
options.AppendExtraBrowserArgs('--expose-internals-for-testing')
def _ContinueTestRunWithTracing(self, tab):
@@ -282,6 +285,7 @@ class _BlinkPerfPaintMeasurement(_BlinkPerfMeasurement):
class _BlinkPerfBenchmark(perf_benchmark.PerfBenchmark):
+
test = _BlinkPerfMeasurement
@classmethod
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698