Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 2868173002: Add PlatformLocalFrame class. (Closed)

Created:
3 years, 7 months ago by joelhockey
Modified:
3 years, 7 months ago
Reviewers:
haraken, dcheng
CC:
apavlov+blink_chromium.org, blink-reviews, blink-reviews-frames_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, krit, dtapuska+blinkwatch_chromium.org, fmalita+watch_chromium.org, fs, gyuyoung2, kinuko+watch, kouhei+svg_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, Navid Zolghadr, pdr+svgwatchlist_chromium.org, pfeldman+blink_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add PlatformLocalFrame class. PlatformLocalFrame is used in PlatformChromeClient as the platform base class for core/frame/LocalFrame This removes a reference to FrameViewBase which is being deleted in http://crrev.com/2855523002. BUG=637460

Patch Set 1 #

Patch Set 2 : this time with new file included #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -36 lines) Patch
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameViewTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.h View 3 chunks +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInputAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/PlatformChromeClient.h View 2 chunks +3 lines, -4 lines 0 comments Download
A third_party/WebKit/Source/platform/PlatformLocalFrame.h View 1 1 chunk +24 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.h View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 1 chunk +10 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/web/ColorChooserPopupUIController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlayAgent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/PopupMenuImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/ValidationMessageClientImpl.cpp View 3 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebPagePopupImpl.cpp View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
joelhockey
I have moved part of http://crrev.com/2855523002 into this separate CL.
3 years, 7 months ago (2017-05-10 00:18:50 UTC) #5
dcheng
I'd prefer to keep plumbing this through as a FrameView rather than the Frame, if ...
3 years, 7 months ago (2017-05-10 00:44:36 UTC) #11
haraken
On 2017/05/10 00:44:36, dcheng wrote: > I'd prefer to keep plumbing this through as a ...
3 years, 7 months ago (2017-05-10 01:08:46 UTC) #12
joelhockey
3 years, 7 months ago (2017-05-10 01:33:26 UTC) #13
On 2017/05/10 at 01:08:46, haraken wrote:
> On 2017/05/10 00:44:36, dcheng wrote:
> > I'd prefer to keep plumbing this through as a FrameView rather than the
Frame,
> > if possible.
> > 
> > In the long-run, I'm hoping we can expose WebWidgetClient directly so we
don't
> > even need to plumb it through ChromeClient, but that's some time away.
> 
> Yeah, agreed. What we need here would be a base class in platform/ that
handles layout-related operations in a Frame. It is a responsibility of
FrameView rather than LocalFrame.

I'll close this CL.  See http://crrev.com/2873213002

Powered by Google App Engine
This is Rietveld 408576698