Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 286813002: [CSS Shapes] line height grows around polygon and incorrectly causes text to wrap to next line (Closed)

Created:
6 years, 7 months ago by rwlbuis
Modified:
6 years, 7 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[CSS Shapes] line height grows around polygon and incorrectly causes text to wrap to next line Correct an earlier PolygonShape fix crbug.com/368686. When the top or bottom of a layout line is coincident with a polygon edge vertex, we only consider it an intersection if the edge extends into the line. This is a merge of http://trac.webkit.org/changeset/168778 by Hans Muller <hmuller@adobe.com>;. BUG=363230 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174333

Patch Set 1 #

Patch Set 2 : Fix prefixes and whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -1 line) Patch
A LayoutTests/fast/shapes/shape-outside-floats/shape-outside-edge-case.html View 1 1 chunk +43 lines, -0 lines 0 comments Download
A LayoutTests/fast/shapes/shape-outside-floats/shape-outside-edge-case-expected.html View 1 1 chunk +39 lines, -0 lines 0 comments Download
M Source/core/rendering/shapes/PolygonShape.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
rwlbuis
PTAL :)
6 years, 7 months ago (2014-05-14 15:35:11 UTC) #1
Hans Muller
On 2014/05/14 15:35:11, rwlbuis wrote: > PTAL :) You should probably excise the -webkit- properties ...
6 years, 7 months ago (2014-05-14 15:37:00 UTC) #2
rwlbuis
PTAL, oneliner fix by Hans.
6 years, 7 months ago (2014-05-14 15:44:53 UTC) #3
rwlbuis
Eric may be a bit busy so also trying Levi.
6 years, 7 months ago (2014-05-19 19:37:34 UTC) #4
eseidel
lgtm
6 years, 7 months ago (2014-05-19 23:52:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/286813002/20001
6 years, 7 months ago (2014-05-19 23:52:52 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 00:39:01 UTC) #7
Message was sent while issue was closed.
Change committed as 174333

Powered by Google App Engine
This is Rietveld 408576698