chrome/browser/file_watcher_win.cc - Issue 2868114: Rework FileWatcher to avoid race condition upon deletion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/file_watcher_win.cc

Issue 2868114: Rework FileWatcher to avoid race condition upon deletion. (Closed) Base URL: http://src.chromium.org/git/chromium.git

Patch Set: Add missing return... Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/file_watcher_win.cc

diff --git a/chrome/browser/file_watcher_win.cc b/chrome/browser/file_watcher_win.cc

index 7d19b32b61edcd706c3d09b19ee7c335363e240d..d4ec0ed85948cdad05c1a398a4d1e850da9f95ff 100644

--- a/chrome/browser/file_watcher_win.cc

+++ b/chrome/browser/file_watcher_win.cc

@@ -27,7 +27,7 @@ class FileWatcherImpl : public FileWatcher::PlatformDelegate,

virtual ~FileWatcherImpl();

// Delegate to notify upon changes.

- FileWatcher::Delegate* delegate_;

+ scoped_refptr<FileWatcher::Delegate> delegate_;

// Path we're watching (passed to delegate).

FilePath path_;

« no previous file with comments | « chrome/browser/file_watcher_unittest.cc ('k') | chrome/browser/user_style_sheet_watcher.h » ('j') | no next file with comments »