chrome/browser/file_watcher_mac.cc - Issue 2868114: Rework FileWatcher to avoid race condition upon deletion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/file_watcher_mac.cc

Issue 2868114: Rework FileWatcher to avoid race condition upon deletion. (Closed) Base URL: http://src.chromium.org/git/chromium.git

Patch Set: Add missing return... Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/file_watcher_mac.cc

diff --git a/chrome/browser/file_watcher_mac.cc b/chrome/browser/file_watcher_mac.cc

index 638654ce8e73b26b110dacb2c45e42f5d646d38e..9bd6d2e20e8fdb331d631905d8d2c1a8751d0fae 100644

--- a/chrome/browser/file_watcher_mac.cc

+++ b/chrome/browser/file_watcher_mac.cc

@@ -76,7 +76,7 @@ class FileWatcherImpl : public FileWatcher::PlatformDelegate {

private:

// Delegate to notify upon changes.

- FileWatcher::Delegate* delegate_;

+ scoped_refptr<FileWatcher::Delegate> delegate_;

// Path we're watching (passed to delegate).

FilePath path_;

« no previous file with comments | « chrome/browser/file_watcher_inotify.cc ('k') | chrome/browser/file_watcher_unittest.cc » ('j') | no next file with comments »