Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1102)

Unified Diff: src/snapshot/deserializer.cc

Issue 2868103002: [deserializer] Make large object deserialization GC safe (Closed)
Patch Set: fix tests for --noopt Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/incremental-marking.cc ('k') | test/cctest/test-serialize.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/snapshot/deserializer.cc
diff --git a/src/snapshot/deserializer.cc b/src/snapshot/deserializer.cc
index 288308776663a389b968e8aca56f09fed65da150..c76e4eca5429698b07f9b04bd2360c3cf3cbc2e8 100644
--- a/src/snapshot/deserializer.cc
+++ b/src/snapshot/deserializer.cc
@@ -148,7 +148,8 @@ MaybeHandle<Object> Deserializer::DeserializePartial(
DeserializeDeferredObjects();
DeserializeEmbedderFields(embedder_fields_deserializer);
- isolate->heap()->RegisterReservationsForBlackAllocation(reservations_);
+ isolate->heap()->RegisterDeserializedObjectsForBlackAllocation(
+ reservations_, &deserialized_large_objects_);
// There's no code deserialized here. If this assert fires then that's
// changed and logging should be added to notify the profiler et al of the
@@ -172,7 +173,8 @@ MaybeHandle<HeapObject> Deserializer::DeserializeObject(Isolate* isolate) {
DeserializeDeferredObjects();
FlushICacheForNewCodeObjectsAndRecordEmbeddedObjects();
result = Handle<HeapObject>(HeapObject::cast(root));
- isolate->heap()->RegisterReservationsForBlackAllocation(reservations_);
+ isolate->heap()->RegisterDeserializedObjectsForBlackAllocation(
+ reservations_, &deserialized_large_objects_);
}
CommitPostProcessedObjects(isolate);
return scope.CloseAndEscape(result);
« no previous file with comments | « src/heap/incremental-marking.cc ('k') | test/cctest/test-serialize.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698