Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: src/heap/spaces.cc

Issue 2868053002: [heap] Verify remembered set for objects in the old generation. (Closed)
Patch Set: remove old to old handling Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/heap.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/spaces.cc
diff --git a/src/heap/spaces.cc b/src/heap/spaces.cc
index afbb452f54527878fe55a8b4034344f51b535627..5b8d8144827b9380c8c8ac8b30518c28eb4a340e 100644
--- a/src/heap/spaces.cc
+++ b/src/heap/spaces.cc
@@ -1565,6 +1565,8 @@ void PagedSpace::Verify(ObjectVisitor* visitor) {
// The object itself should look OK.
object->ObjectVerify();
+ heap()->VerifyRememberedSetFor(object);
+
// All the interior pointers should be contained in the heap.
int size = object->Size();
object->IterateBody(map->instance_type(), size, visitor);
@@ -3317,6 +3319,8 @@ void LargeObjectSpace::Verify() {
// The object itself should look OK.
object->ObjectVerify();
+ heap()->VerifyRememberedSetFor(object);
+
// Byte arrays and strings don't have interior pointers.
if (object->IsAbstractCode()) {
VerifyPointersVisitor code_visitor;
« no previous file with comments | « src/heap/heap.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698