Issue 2868021: Mac: Play with using a prefix header.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2868021: Mac: Play with using a prefix header. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 11 months ago by Nico

Modified:
4 years ago

Reviewers:

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org

Visibility:
Public.

Description

Mac: Play with using a prefix header. (not for check-in or review) "Improves" clean build times by -4 minutes from 8 to 12 minutes on my mac pro. Might be better on an mbp, might be better if the prefix header is used only in projects actually using cocoa.

Patch Set 1 #

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	build/common.gypi	View		1 chunk	+2 lines, -1 line	0 comments	Download
	A	build/prefix_header_mac.h	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Trybot results: