Chromium Code Reviews
Help | Chromium Project | Sign in
(9)

Issue 2868020: Log the value of RUNNING_ON_VALGRIND in message_loop.cc (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 11 months ago by Alexander Potapenko
Modified:
4 years ago
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Log the value of RUNNING_ON_VALGRIND in message_loop.cc BUG=46569 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50454

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M base/message_loop.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
Commit: CQ not working?

Messages

Total messages: 3 (0 generated)
Alexander Potapenko
Folks, Let's land this patch for one bot cycle and see if that helps to ...
4 years, 11 months ago (2010-06-22 08:39:35 UTC) #1
willchan no longer on Chromium
LGTM On Tue, Jun 22, 2010 at 1:39 AM, <glider@chromium.org> wrote: > Reviewers: willchan, rvargas, ...
4 years, 11 months ago (2010-06-22 14:04:05 UTC) #2
willchan no longer on Chromium
4 years, 11 months ago (2010-06-22 18:27:16 UTC) #3
http://build.chromium.org/buildbot/memory/builders/Chromium%20OS%20UI%20(valg...

RUNNING_ON_VALGRIND is 0!

[27536:6156:0622/101740:15878829297951:INFO:base/message_loop.cc(392)]
MessageLoop::DeletePendingTasks(): RUNNING_ON_VALGRIND=0
[27536:6156:0622/101740:15878829298063:INFO:base/message_loop.cc(392)]
MessageLoop::DeletePendingTasks(): RUNNING_ON_VALGRIND=0
[27536:27536:0622/101740:15878829299828:INFO:base/message_loop.cc(392)]
MessageLoop::DeletePendingTasks(): RUNNING_ON_VALGRIND=0
[27536:27536:0622/101740:15878829299863:INFO:base/message_loop.cc(392)]
MessageLoop::DeletePendingTasks(): RUNNING_ON_VALGRIND=0
[27536:27536:0622/101740:15878829299880:INFO:base/message_loop.cc(392)]
MessageLoop::DeletePendingTasks(): RUNNING_ON_VALGRIND=0
[27536:27536:0622/101740:15878829299895:INFO:base/message_loop.cc(392)]
MessageLoop::DeletePendingTasks(): RUNNING_ON_VALGRIND=0

On Tue, Jun 22, 2010 at 7:03 AM, William Chan (陈智昌)
<willchan@chromium.org> wrote:
> LGTM
>
> On Tue, Jun 22, 2010 at 1:39 AM,  <glider@chromium.org> wrote:
>> Reviewers: willchan, rvargas,
>>
>> Message:
>> Folks,
>>
>> Let's land this patch for one bot cycle and see if that helps to detect the
>> problem with RUNNING_ON_VALGRIND on CrOS bots.
>>
>> Description:
>> Log the value of RUNNING_ON_VALGRIND in message_loop.cc
>>
>> BUG=46569
>>
>> Please review this at http://codereview.chromium.org/2868020/show
>>
>> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>>
>> Affected files:
>>  M     base/message_loop.cc
>>
>>
>> Index: base/message_loop.cc
>> ===================================================================
>> --- base/message_loop.cc        (revision 50337)
>> +++ base/message_loop.cc        (working copy)
>> @@ -388,6 +388,8 @@
>>
>>  bool MessageLoop::DeletePendingTasks() {
>>   bool did_work = !work_queue_.empty();
>> +  LOG(INFO) << "MessageLoop::DeletePendingTasks(): RUNNING_ON_VALGRIND="
>> +            << RUNNING_ON_VALGRIND;
>>   while (!work_queue_.empty()) {
>>     PendingTask pending_task = work_queue_.front();
>>     work_queue_.pop();
>>
>>
>>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be