Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: tools/binary_size/libsupersize/models.py

Issue 2868003003: supersize: Update README.md with technical details. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/binary_size/libsupersize/describe.py ('k') | tools/binary_size/libsupersize/testdata/Console.golden » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/binary_size/libsupersize/models.py
diff --git a/tools/binary_size/libsupersize/models.py b/tools/binary_size/libsupersize/models.py
index ce7f6e89fdfd7d38cefebce44f671c97c8fa9d83..b30c61184df63e02250f0ff1ce61a027cd76cf1f 100644
--- a/tools/binary_size/libsupersize/models.py
+++ b/tools/binary_size/libsupersize/models.py
@@ -355,9 +355,9 @@ class SymbolGroup(BaseSymbol):
def pss(self):
if self._pss is None:
if self.IsBss():
- self._pss = float(self.size)
- else:
self._pss = sum(s.pss for s in self)
+ else:
+ self._pss = sum(s.pss for s in self if not s.IsBss())
return self._pss
@property
« no previous file with comments | « tools/binary_size/libsupersize/describe.py ('k') | tools/binary_size/libsupersize/testdata/Console.golden » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698