content/common/device_sensors/device_light_data.h - Issue 286793002: [DeviceLight] Add renderer+common parts

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/common/device_sensors/device_light_data.h

Issue 286793002: [DeviceLight] Add renderer+common parts (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Work on Tim's comments Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « content/common/content_message_generator.h ('k') | content/common/device_sensors/device_light_data.cc » ('j') | content/common/device_sensors/device_light_data.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CONTENT_COMMON_DEVICE_SENSORS_DEVICE_LIGHT_DATA_H_

	6 #define CONTENT_COMMON_DEVICE_SENSORS_DEVICE_LIGHT_DATA_H_

	7

	8 #include "content/common/content_export.h"

	9

	10 namespace content {

	11

	12 class DeviceLightData {

	13 public:

	14 CONTENT_EXPORT DeviceLightData();

	15 ~DeviceLightData() { }

	16

	17 double value;
	jochen (gone - plz use gerrit) 2014/06/12 14:33:50 this class doesn't follow the coding style at all. this class doesn't follow the coding style at all. data members should be private. don't unnecessarily create bitfields. add disallow copy/assign. add getters/setters timvolodine 2014/06/12 15:25:28 re getters/setters: this class is intentionally PO Show quoted text On 2014/06/12 14:33:50, jochen traveling until Jun 23 wrote: > this class doesn't follow the coding style at all. > > data members should be private. don't unnecessarily create bitfields. add > disallow copy/assign. add getters/setters re getters/setters: this class is intentionally POD, because it is used for shared memory. Similar classes can be found in third_party/WebKit/public/platform/ e.g. WebGamepads.h. probably should add a comment: // This class is intentionally POD and fixed size so that it can be stored // in shared memory between the browser and the renderer processes. riju_ 2014/06/13 17:06:25 Done. As Tim suggested, adding a comment why this Show quoted text On 2014/06/12 14:33:50, jochen traveling until Jun 23 wrote: > this class doesn't follow the coding style at all. > > data members should be private. don't unnecessarily create bitfields. add > disallow copy/assign. add getters/setters Done. As Tim suggested, adding a comment why this class does not follow chromium coding style.
	18 bool valueIsUpdated : 1;

	19 };

	20

	21 } // namespace content

	22

	23 #endif // CONTENT_COMMON_DEVICE_SENSORS_DEVICE_LIGHT_DATA_H_

	24

OLD	NEW