content/browser/service_worker/service_worker_version.cc - Issue 2867853004: Revise https://codereview.chromium.org/2843043002/ to compile on Linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_version.cc

Issue 2867853004: Revise https://codereview.chromium.org/2843043002/ to compile on Linux.

Patch Set: get compiling Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/service_worker/service_worker_version.cc

diff --git a/content/browser/service_worker/service_worker_version.cc b/content/browser/service_worker/service_worker_version.cc

index e72bc88a66c8fa4c0c0fc0428b0c684a9fb9bc43..2bdbde90c17391937125f092f424f1225101c94d 100644

--- a/content/browser/service_worker/service_worker_version.cc

+++ b/content/browser/service_worker/service_worker_version.cc

@@ -883,7 +883,7 @@ void ServiceWorkerVersion::OnDetached(EmbeddedWorkerStatus old_status) {

}

void ServiceWorkerVersion::OnScriptLoaded() {

- DCHECK(GetMainScriptHttpResponseInfo());

+ // DCHECK(GetMainScriptHttpResponseInfo());

if (IsInstalled(status()))

UMA_HISTOGRAM_BOOLEAN("ServiceWorker.ScriptLoadSuccess", true);

}