chrome/browser/supervised_user/supervised_user_google_auth_navigation_throttle.cc - Issue 2867833002: NavigationThrottle: allow customization of net::Error when blocking

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/supervised_user/supervised_user_google_auth_navigation_throttle.cc

Issue 2867833002: NavigationThrottle: allow customization of net::Error when blocking

Patch Set: Add unit tests. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/subresource_filter/subresource_filter_unittest.cc ('k') | chrome/browser/supervised_user/supervised_user_navigation_throttle.cc » ('j') | content/browser/frame_host/navigation_request.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/supervised_user/supervised_user_google_auth_navigation_throttle.cc

diff --git a/chrome/browser/supervised_user/supervised_user_google_auth_navigation_throttle.cc b/chrome/browser/supervised_user/supervised_user_google_auth_navigation_throttle.cc

index 1931a03bb52b1fa2c54490c780cdf0b71460b6e7..f15f46212c143a9d46b765103ba149dd3eb433ff 100644

--- a/chrome/browser/supervised_user/supervised_user_google_auth_navigation_throttle.cc

+++ b/chrome/browser/supervised_user/supervised_user_google_auth_navigation_throttle.cc

@@ -74,7 +74,7 @@ SupervisedUserGoogleAuthNavigationThrottle::WillStartOrRedirectRequest() {

content::NavigationThrottle::ThrottleCheckResult result =

ShouldProceed(child_account_service_->IsGoogleAuthenticated());

- if (result == content::NavigationThrottle::DEFER) {

+ if (result.action() == content::NavigationThrottle::DEFER) {

google_auth_state_subscription_ =

child_account_service_->ObserveGoogleAuthState(

base::Bind(&SupervisedUserGoogleAuthNavigationThrottle::

@@ -90,7 +90,7 @@ void SupervisedUserGoogleAuthNavigationThrottle::OnGoogleAuthStateChanged(

content::NavigationThrottle::ThrottleCheckResult result =

ShouldProceed(authenticated);

- switch (result) {

+ switch (result.action()) {

case content::NavigationThrottle::PROCEED: {

google_auth_state_subscription_.reset();

navigation_handle()->Resume();