Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2867763003: Make Future._nullFuture be initialized synchronously. (Closed)

Created:
3 years, 7 months ago by Lasse Reichstein Nielsen
Modified:
3 years, 7 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make Future._nullFuture be initialized synchronously. Also type it as Future<Null> now that it makes sense. Because there is no reason not to. R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/7157b6aef25a346120de1d080af09b10799a370d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M sdk/lib/async/future.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Lasse Reichstein Nielsen
3 years, 7 months ago (2017-05-09 11:39:13 UTC) #3
floitsch
LGTM.
3 years, 7 months ago (2017-05-09 12:11:18 UTC) #4
Lasse Reichstein Nielsen
3 years, 7 months ago (2017-05-10 07:21:12 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7157b6aef25a346120de1d080af09b10799a370d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698