Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2867733002: GN: On Linux still fallback to GCC for ARM64 build. (Closed)

Created:
3 years, 7 months ago by Vyacheslav Egorov (Google)
Modified:
3 years, 7 months ago
Reviewers:
zra, sortie, kustermann
CC:
reviews_dartlang.org, sortie
Target Ref:
refs/heads/master
Visibility:
Public.

Description

GN: On Linux still fallback to GCC for ARM64 build. We don't have clang arm64 toolchain. BUG= R=kustermann@google.com, sortie@google.com Committed: https://github.com/dart-lang/sdk/commit/c162e0f011a019b21d17e16c6c39b2e228e11dc0

Patch Set 1 #

Patch Set 2 : Done #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/gn.py View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Vyacheslav Egorov (Google)
PTAL
3 years, 7 months ago (2017-05-08 08:32:25 UTC) #3
sortie
lgtm, thanks!
3 years, 7 months ago (2017-05-08 08:35:39 UTC) #5
kustermann
lgtm
3 years, 7 months ago (2017-05-08 09:24:34 UTC) #6
Vyacheslav Egorov (Google)
3 years, 7 months ago (2017-05-08 09:30:37 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c162e0f011a019b21d17e16c6c39b2e228e11dc0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698