bluetooth: Implement known_service_uuids for Peripherals.

third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js

Index: third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js
diff --git a/third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js b/third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js
index 08901e571c71394ea2dcdd3f8f1e8e23283ad9cb..60cd8ae5619bf403441a7d903737571ecb0e2ee1 100644
--- a/third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js
+++ b/third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js
@@ -12,6 +12,10 @@ var request_disconnection_characteristic_uuid =
 // Descriptors:
 var blocklist_test_descriptor_uuid = "bad2ddcf-60db-45cd-bef9-fd72b153cf7c";
 
+// Addresses for peripherals.
+const ADDRESS1 = '00:00:00:00:00:00';

[scheib, 2017/05/09 23:33:54]

Will any code other than setup methods use these values? If not, then may as
well keep the literal values inline in the setup methods. If it's good enough
for device names, why not addresses?

Or we will need to reference them? If so, seems silly to have address1 == 00.
Maybe something more meaningful?:
LE_DEVICE_ADDRESS = "01:01:01:01:01:01"
HEALTH_THERMOMETER_ADDRESS = "02:02:02:02:02:02"
HEART_RATE_ADDRESS = "03:03:03:03:03:03"

[ortuno, 2017/05/10 06:32:50]

We might when we add advertisements but I'm OK with inlining in the mean time.
The use case, which I experienced when building the C++ fakes framework, I had
in mind was the following:

In a test:
1. Use one of the setup methods.
2. Try to add your own device to central.
3. Be confused as to why the device is not showing up.
4. Realize that your new device was using an address already used.

To avoid ADDRESS*, I changed to keep the strings inline and made the addresses
less common to avoid collisions.

[scheib, 2017/05/10 17:51:14]

OK, yeah we could just use a random number literal each time (I think my pref).
Or, could have a test helper method that vends out unique addresses. 

+const ADDRESS2 = '11:11:11:11:11:11';
+
 // Sometimes we need to test that using either the name, alias, or UUID
 // produces the same result. The following objects help us do that.
 var generic_access = {
@@ -423,10 +427,25 @@ function generateRequestDeviceArgsWithServices(services = ['heart_rate']) {
   }];
 }
 
-function setUpPreconnectedDevice({address = '00:00:00:00:00:00', name}) {
+function setUpPreconnectedDevice({
+  address = ADDRESS1, name = 'LE Device', knownServiceUUIDs = []}) {
   return navigator.bluetooth.test.simulateCentral({state: 'powered-on'})
     .then(fake_central => fake_central.simulatePreconnectedPeripheral({
       address: address,
-      name: name
+      name: name,
+      knownServiceUUIDs: knownServiceUUIDs,
     }));
 }
+
+function setUpHealthThermometerHeartRate() {

[scheib, 2017/05/09 23:33:54]

setUpHealthThermometerAndHeartRateDevices
                      ^^^         ^^^^^^^

[ortuno, 2017/05/10 06:32:50]

Done. I was trying to keep our names as short as possible.

+  return setUpPreconnectedDevice({

[scheib, 2017/05/09 23:33:54]

Calling setUpPreconnectedDevice multiple times, resulting in multiple calls to
simulateCentral, seems odd. I think I'd rather see a duplicate call to
simulateCentral, and then multiple .simulatePreconnectedPeripheral calls.

See note in simulateCentral...

[ortuno, 2017/05/10 06:32:50]

I was hoping to make it so that a test could call setUpPreconnectedDevice
multiple times.

return setUpPreconnectedDevice({address: makeMACAddress(0x01), name: 'dev1'})
  .then(() => setUpPreconnectedDevice({address: makeMACAddress(0x02), name:
'dev2'})
  .then(() => setUpPreconnectedDevice({address: makeMACAddress(0x03), name:
'dev3'})

vs.

return navigator.bluetooth.test.simulateCentral({state: 'powered-on'})
  .then(fake_central => {
    return fake_central.simulatePreconnectedPeripheral({
      address: makeMACAddress(0x01), name: 'dev1'})
      .then(() => fake_central.simulatePreconnectedPeripheral({
        address: makeMACAddress(0x02), name: 'dev2'})
      .then(() => fake_central.simulatePreconnectedPerupheral({
        address: makeMACAddress(0x03), name: 'dev3'})
  });

But I guess we can revisit if/when tests like that pop up.

Done.

+      address: ADDRESS1,
+      name: 'Health Thermometer',
+      knownServiceUUIDs: ['generic_access', 'health_thermometer'],
+  })
+  .then(() => setUpPreconnectedDevice({
+    address: ADDRESS2,
+    name: 'Heart Rate',
+    knownServiceUUIDs: ['generic_access', 'heart_rate'],
+  }));
+}